search

coachcare / npm-datepicker

Material Datepicker Fork with TimePicker by CoachCare
MIT License
32 stars 18 forks source link

Fix datepicker input always being disabled #45

Open davidstritzl opened 3 years ago

davidstritzl commented 3 years ago

This PR fixes the datepicker input element always being disabled regardless of the disabled input attribute. This is caused by passing a boolean for the disabled attribute to the host input element, which will be implicitly converted to the strings "true" or "false", dependently on the boolean value, however, according to the HTML5 standard, boolean attributes with false values must be left out completely (and true values can be either an empty string or the attribute name itself).

matheo commented 3 years ago

Thanks for this PR @davidstritzl I just released @coachcare/datepicker v1.0.3 with this fix.

Take in account that this package is deprecated by @matheo/datepicker for Angular v11