Open fregante opened 1 year ago
Thanks for linking the documentation. It was believed that this installation could have been an accident or some form of experimentation. We couldn't find a documentation noting XVFB officially so we continued to use the action. ✅ Support
Here's an updated link https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md
This action works on all OS, while the GA one works only on Linux
This action works on all OS, while the GA one works only on Linux
- if: runner.os == 'Linux'
run: xvfb-run npm test
- if: runner.os != 'Linux'
run: npm test
This action works on all OS, while the GA one works only on Linux
- if: runner.os == 'Linux' run: xvfb-run npm test - if: runner.os != 'Linux' run: npm test
This is still not really an alternative as one now needs to replicate all steps in a matrix, so can this action not simply wrap the call if appropriate and be a noop otherwhise?
This action works on all OS, while the GA one works only on Linux
- if: runner.os == 'Linux' run: xvfb-run npm test - if: runner.os != 'Linux' run: npm test
This is still not really an alternative as one now needs to replicate all steps in a matrix, so can this action not simply wrap the call if appropriate and be a noop otherwhise?
If you don't want to replicate the steps, just specify the condition like this:
run: ${{ matrix.os == 'ubuntu-latest' && 'xvfb-run' || '' }} npm test
See at the bottom of: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md
And a successful run at https://github.com/fregante/text-field-edit/actions/runs/6107546540/workflow#L28
I'd probably add a notice to the repo and/or deprecate it.