search

coactions / setup-xvfb

Run your tests headlessly by enabling xvfb
https://github.com/marketplace/actions/setup-xvfb
MIT License
50 stars 9 forks source link

This action is no longer needed, GitHub Actions (ubuntu) ships with xvfb #21

Open fregante opened 1 year ago

fregante commented 1 year ago

See at the bottom of: https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md

And a successful run at https://github.com/fregante/text-field-edit/actions/runs/6107546540/workflow#L28

I'd probably add a notice to the repo and/or deprecate it.

zm-cttae commented 1 year ago

Thanks for linking the documentation. It was believed that this installation could have been an accident or some form of experimentation. We couldn't find a documentation noting XVFB officially so we continued to use the action. ✅ Support

bobbyg603 commented 11 months ago

Here's an updated link https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md

mmomtchev commented 9 months ago

This action works on all OS, while the GA one works only on Linux

cclauss commented 7 months ago

This action works on all OS, while the GA one works only on Linux

- if: runner.os == 'Linux'
  run: xvfb-run npm test
- if: runner.os != 'Linux'
  run: npm test
fregante commented 7 months ago
laeubi commented 1 month ago

This action works on all OS, while the GA one works only on Linux

- if: runner.os == 'Linux'
  run: xvfb-run npm test
- if: runner.os != 'Linux'
  run: npm test

This is still not really an alternative as one now needs to replicate all steps in a matrix, so can this action not simply wrap the call if appropriate and be a noop otherwhise?