coactum / moodle-mod_margic

A moodle plugin that allows participants to create unlimited entries which can then be evaluated and annotated by teachers.
Other
4 stars 3 forks source link

Error in line 43 of edit.php: Wrong default value #3

Closed HarryBleckert closed 1 year ago

HarryBleckert commented 1 year ago

We are using Moodle 3.11.12+ with latest Margic version 1.2.7 and found an error in line 43 of edit.php: Wrong default value

We always encountered a DB error "invalid entry" on a fresh margic installation when clicking on "New Entry"

We found this in line 43 of edit.php $entryid = optional_param('entryid', '', PARAM_INT); must be changed to $entryid = optional_param('entryid', 0, PARAM_INT);

ksteitz commented 1 year ago

works using Moodle 3.11.12 and PostgreSQL, but still bugs left using pg, see https://github.com/coactum/moodle-mod_margic/issues/4#issuecomment-1406379508

dtnolte commented 1 year ago

Hi, thank you for reporting this error and sorry for my late reply. Im preparing a new version for the plugin where this error (along with the other big postgreSQL error #4) will be fixed.