coadmunkee / gnome-shell-extension-espresso

Enable controlling conditions to prevent the usual auto suspend and screensaver functions from taking effect.
https://extensions.gnome.org/extension/4135/espresso/
GNU General Public License v2.0
69 stars 14 forks source link

Pause for defined applications only does not turn off #22

Open forteller opened 2 years ago

forteller commented 2 years ago

Hi. Thanks for a great extension! Really nice quality of life improvement for me.

I've noticed a bug: After adding applications to the list of "Pause/resume NL for defined applications only" but then switching that option off, the Night Light still turns off when I open those applications.

Ubuntu 21.10, Gnome 40.4, Gnome-session, both X and Wayland.

Hope you can look into that. Thanks!

coadmunkee commented 2 years ago

Will look into it, but it will be at least a week before I can try. Out of town without my laptop

forteller commented 2 years ago

Hey, no problem at all! Thanks for the update! :)

coadmunkee commented 2 years ago

I took a look into this and have a feeling that things are work as designed, but maybe the functionality isn't described well.

When "Pause/resume Night Light if enabled" is turned on and "Pause/resume Night Light for defined application is only" is NOT turned on:

The Night Light is paused whenever Espresso is active and resumes whenever Espresso is deactivated. This includes pausing Night Light both when Espresso is enabled by clicking on the cup to fill it or when Espresso is enabled by opening one of the listed applications.

When "Pause/resume Night Light if enabled" is turned on and "Pause/resume Night Light for defined application is only" is also turned on:

The Night Light is paused only when Espresso is active and has been enabled dues to one of the listed applications being opened. Night Light resumes whenever Espresso is deactivated AND none of the listed applications are open.

Please let me know if this doesn't explain what you are seeing happening with Espresso.