search

coala / cEPs

coala Enhancement Proposals
MIT License
33 stars 53 forks source link

cEP-0021: Profile Bears #153

Closed RaiVaibhav closed 6 years ago

RaiVaibhav commented 6 years ago

Proposed implementation of Profiling Interface.

Closes https://github.com/coala/cEPs/issues/154

(follows https://github.com/coala/cEPs/pull/132)

fneu commented 6 years ago

ack https://github.com/coala/cEPs/pull/153/commits/0ea5d4a0ffe0cf29005b173af37295fcc9d1e0c8

Makman2 commented 6 years ago

Let's get some initial state merged, but imo needs still improvement. Could have some more explanations and details (e.g. the binary output and compatibility considerations with existing profiling tools).

Makman2 commented 6 years ago

ack 0ea5d4a0ffe0cf29005b173af37295fcc9d1e0c8 bca2ed4cf5980ee7f503016f9a71a2259187f264

Makman2 commented 6 years ago

@gitmate-bot rebase

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated rebase with GitMate.io was successful! :tada:

RaiVaibhav commented 6 years ago

PR has been updated :+1:

fneu commented 6 years ago

ack e8ba031

fneu commented 6 years ago

ack bff32d3

RaiVaibhav commented 6 years ago

Updated the little fixes :+1:

Makman2 commented 6 years ago

Let's merge for now, in general okay. We will continue improving the language and concept further in the next versions asap.

CC @jayvdb

jayvdb commented 6 years ago

add https://github.com/coala/cEPs/pull/153/commits/d7de1896ed3e9370a431987a210a82751e211066 https://github.com/coala/cEPs/pull/153/commits/5fe54732ecbae5b59231461670dc6fde63c530a8

jayvdb commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: