search

coala / cEPs

coala Enhancement Proposals
MIT License
33 stars 53 forks source link

cEP-0028: Optimizing coala for language server #171

Closed ksdme closed 6 years ago

ksdme commented 6 years ago

This proposal describes techniques to optimize coala language server.

Closes https://github.com/coala/cEPs/issues/156

ksdme commented 6 years ago

The current filters are only being used with --show-bears for bear filtering mechanism but the TagFilter needs to be run during section filtering and be handled in run_coala() as opposed to coala_main(). The current filters work on classes rather than on instances, this makes it necessary for TagFilter to be a section filter rather than a bear filter accessing a bear’s section property. We may need to have a new apply_section_filter() in FilterHelper and use it in run_coala prior to checked for the enabled flag on a section. We may also need a way to differentiate section filters from bear filters as section filters cannot be used during --show-bears. There is a possibility that we can have enabled checking in a EnabledFilter section filter.

Makman2 commented 6 years ago

Looks good in principle :+1:

jayvdb commented 6 years ago

@gitmate-bot rebase

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated rebase with GitMate.io was successful! :tada:

jayvdb commented 6 years ago

ack https://github.com/coala/cEPs/pull/171/commits/07a63ec9661b1d32f7fc7002bf14f74cfc77447e

jayvdb commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward failed! Please fastforward your pull request manually via the command line.

Reason:

Command: git push upstream HEAD:master

Exit Code: 128

Cause:

fatal: unable to access '<hidden_oauth_token>/': Could not resolve host: github.com
jayvdb commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: