search

coala / cEPs

coala Enhancement Proposals
MIT License
33 stars 53 forks source link

cEP-0035: Extending support for newer versions of Python #192

Closed anshalshukla closed 3 years ago

anshalshukla commented 3 years ago

This proposal describes the approach that will be followed to enable coala work with newer version of Python.

closes #191

abhishalya commented 3 years ago

Please no more commits like aa, aaa. It's an extremely bad practice to write such commits.

anshalshukla commented 3 years ago

I had to change the commit message to "Add support for newer versions of Python" because having "Extending" makes the commit headlog imperative. coala throws an error with that. Let me know if I should change that project-wide.

abhishalya commented 3 years ago

@anshalshukla Please make necessary changes, and rebase. This needs to be merged today.

anshalshukla commented 3 years ago

@abhishalya Will do it soon.

anshalshukla commented 3 years ago

@abhishalya, I guess this looks fine now?

abhishalya commented 3 years ago

Resolve conflicts as well please.

anshalshukla commented 3 years ago

@abhishalya Done!

abhishalya commented 3 years ago

@anshalshukla You didn't write valid commit short log. Please read the commit guidelines thoroughly.

closes coala#191

Please take care of these things before writing any commit. This PR is unmergable until everything is done properly.

anshalshukla commented 3 years ago

@abhishalya Can I get this merged now.