search

coala / coAST

Universal and language-independent abstract syntax tree
45 stars 33 forks source link

D.yaml: Fix typo in line 10 "delimiters". #87

Closed CleverFool77 closed 5 years ago

CleverFool77 commented 5 years ago

Fixes: #69

I haven't received my Coala organisation invite yet. But I wanted to get started with contributing in Coala, So I made this Pull Request.

jayvdb commented 5 years ago

Comment on 7613074315dbfc2a5a29e005ec1188d1a0ece0de, file data/Language/VisualBasic.yaml, line 5.

line too long (82 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: yaml.

CleverFool77 commented 5 years ago

@jayvdb I didn't edit that file which shows (82>80) characters . Also that line is a url link with less chances of reducing two characters.

naveentvelu commented 5 years ago

@CleverFool77 You can refer to either Javascript.yaml or verilog.yaml where the grammar_file is written in two lines. This might help. :)

jayvdb commented 5 years ago

Comment on 44e054d099e98e5459239504b469843dce474609, file data/Language/VisualBasic.yaml, line 5.

line too long (82 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: yaml.

CleverFool77 commented 5 years ago

The commit fixes the line length in VisualBasic.yaml and typo in D.yaml.

jayvdb commented 5 years ago

@gitmate-bot rebase

jayvdb commented 5 years ago

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:

jayvdb commented 5 years ago

Automated rebase with GitMate.io was successful! :tada:

CleverFool77 commented 5 years ago

I'll open a new pr and closing this pr for now.

utkarsh2102 commented 5 years ago

@CleverFool77, you should never close PRs. Work on this one. You would get to learn a lot. Opening another PR is not the solution.

CleverFool77 commented 5 years ago

@utkarsh2102 While comparing for the merge conflict, I got to know that this issue has already been resolved. Since the issue has already been resolved, it's good to close this PR.