.coafile: Add PEP8Bear - Githubissues

coala / coala-atom

A coala integration plugin for Atom

https://coala.io/

GNU Affero General Public License v3.0

20 stars 23 forks source link

.coafile: Add PEP8Bear #47

Closed RohanVB closed 7 years ago

supergr35 commented 7 years ago

@EverWinter23 you can't put the ack in the approval review, it has to be in a comment.

supergr35 commented 7 years ago

rebase and we're set :+1:

RohanVB commented 7 years ago

@Madhukar-SH The file doesn't even have extra spaces. It is exactly as the fix shows it should be already :/

This is what it looks like already:

1. Install [coala](https://github.com/coala/coala)
2. `apm install coala` or use the atom GUI

   Note:

   - If the [linter](https://github.com/steelbrain/linter) atom package is not currently installed, it will be installed for you.
   - If you are behind a firewall and seeing SSL errors when installing packages, you may find the fix at [atom manual](http://flight-manual.atom.io/

kaustubhhiware commented 7 years ago

Hey @RohanVB , please follow the guidelines here for making a good commit - http://coala.io/commit

RohanVB commented 7 years ago

Thanks @kaustubhhiware :) Reason why I didn't follow that: 1) There's no issue for it, just a minor update (hence the lack of the issue reference) 2) It's mainly enforced for the main coala and coala-bears repos

madhukar01 commented 7 years ago

How did you fix? With rebase?

madhukar01 commented 7 years ago

ack 0c29194

RohanVB commented 7 years ago

@Madhukar-SH Apparently the issue with gitmate was fixed with git pull origin master on my atombranch3 branch, I didn't notice it wasn't up-to-date. The issue that I opened an issue for is separate and is still reproducible by creating a clone of this repo and running coala on it. The patch deletes the entire file. (Note: The issue is a duplicate of a pre-existing one which is related to markdownbear).