main.coffee: Fix old version warning

[ed4140]

Fix old version warning even when the latest is installed. Versions were compared as strings, so '0.10.0' was less than '0.9.1' Replaced comparison with a proper function.

Fixes https://github.com/coala/coala-atom/issues/48

[EverWinter23]

Hey, @ed4140, you are not following commit message guidelines. Commit body lines should not exceed 72 characters. circle-ci test is failing for this reason.

[EverWinter23]

Run coala with SpaceConsistencyBear before submitting.

[EverWinter23]

unack 0106980ac7dfe31edeec8d5a2064abf4a99996ca

[ed4140]

What is the problem if README.md was not changed?

[RohanVB]

You still have your old commits. You should squash/remove them if they aren't necessary.

[ed4140]

Well, I hope that now it is ok

[madhukar01]

@ed4140 Please do run py.test and coala on your local machine inside the directory from next time. So that these gitmate reviews will be fixed before you push :)

[RohanVB]

@ed4140 you didn't address the reviews in your code. Also, you need an issue reference in the commit.

@Madhukar-SH we don't have py.test tests set up on this repo yet.

[sils]

btw. big :+1: for doing this :)

[ed4140]

@sils Now rebased, function returns a boolean and added a comment

As for tuples - its really nice trick but unfortunately I couldn't find something like this for coffeescript

[ed4140]

@sils No problem, done:)

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[gitmate-bot]

Hey! This wasn't updated since a while. Please check up on it!

[blazeu]

Hello @ed4140 are you still on this? coala-atom is not usable if this is not fixed.

You can use https://www.npmjs.com/package/semver to check for versioning instead of writing your own function.

[Makman2]

Closing due to inactivity.