search

coala / coala-atom

A coala integration plugin for Atom
https://coala.io/
GNU Affero General Public License v3.0
20 stars 23 forks source link

main.coffee: Updates coala's min version to 0.10.0 #55

Closed EverWinter23 closed 7 years ago

EverWinter23 commented 7 years ago

update COALA_MIN_VERSION from '0.9.1' to '0.10.0'

alisianoi commented 7 years ago

Hey, @EverWinter23 , you are not following commit message guidelines

In particular, please use imperative: Updated -> Update

Also, circleci appears to be failing because of some unrelated issue.

EverWinter23 commented 7 years ago

Should i keep working on it?

RohanVB commented 7 years ago

Try to figure out what's causing circleci to fail on this build. When I pushed the same PR, ci passed. (https://github.com/coala/coala-atom/pull/44)

Also, fix the commit message. See: http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

gitmate-bot commented 7 years ago

Comment on d06e873d3ef3d9d6d5e7b0386332c057e08df3f0, file README.md, line 9.

The text does not comply to the set style.

MarkdownBear, severity NORMAL, section markdown.

The issue can be fixed by applying the following patch:

--- a/README.md
+++ b/README.md
@@ -6,12 +6,13 @@

 # INSTALLATION

-1.  Install [coala](https://github.com/coala/coala)
-2.  `apm install coala` or use the atom GUI
+1. Install [coala](https://github.com/coala/coala)
+2. `apm install coala` or use the atom GUI

-    Note:
-     * If the `linter` atom package is not currently installed, it will be installed for you.
-     * If you are behind a firewall and seeing SSL errors when installing packages, you may find the fix at [atom manual](http://flight-manual.atom.io/getting-started/sections/installing-atom/#setting-up-a-proxy)
+   Note:
+
+   - If the `linter` atom package is not currently installed, it will be installed for you.
+   - If you are behind a firewall and seeing SSL errors when installing packages, you may find the fix at [atom manual](http://flight-manual.atom.io/getting-started/sections/installing-atom/#setting-up-a-proxy)

 # AUTHORS
gitmate-bot commented 7 years ago

Comment on d06e873d3ef3d9d6d5e7b0386332c057e08df3f0, file README.md, line 9.

The text does not comply to the set style.

MarkdownBear, severity NORMAL, section markdown.

The issue can be fixed by applying the following patch:

--- a/README.md
+++ b/README.md
@@ -6,12 +6,13 @@

 # INSTALLATION

-1.  Install [coala](https://github.com/coala/coala)
-2.  `apm install coala` or use the atom GUI
+1. Install [coala](https://github.com/coala/coala)
+2. `apm install coala` or use the atom GUI

-    Note:
-     * If the `linter` atom package is not currently installed, it will be installed for you.
-     * If you are behind a firewall and seeing SSL errors when installing packages, you may find the fix at [atom manual](http://flight-manual.atom.io/getting-started/sections/installing-atom/#setting-up-a-proxy)
+   Note:
+
+   - If the `linter` atom package is not currently installed, it will be installed for you.
+   - If you are behind a firewall and seeing SSL errors when installing packages, you may find the fix at [atom manual](http://flight-manual.atom.io/getting-started/sections/installing-atom/#setting-up-a-proxy)

 # AUTHORS
gitmate-bot commented 7 years ago

Comment on d06e873d3ef3d9d6d5e7b0386332c057e08df3f0, file README.md, line 9.

The text does not comply to the set style.

MarkdownBear, severity NORMAL, section markdown.

The issue can be fixed by applying the following patch:

--- a/README.md
+++ b/README.md
@@ -6,12 +6,13 @@

 # INSTALLATION

-1.  Install [coala](https://github.com/coala/coala)
-2.  `apm install coala` or use the atom GUI
+1. Install [coala](https://github.com/coala/coala)
+2. `apm install coala` or use the atom GUI

-    Note:
-     * If the `linter` atom package is not currently installed, it will be installed for you.
-     * If you are behind a firewall and seeing SSL errors when installing packages, you may find the fix at [atom manual](http://flight-manual.atom.io/getting-started/sections/installing-atom/#setting-up-a-proxy)
+   Note:
+
+   - If the `linter` atom package is not currently installed, it will be installed for you.
+   - If you are behind a firewall and seeing SSL errors when installing packages, you may find the fix at [atom manual](http://flight-manual.atom.io/getting-started/sections/installing-atom/#setting-up-a-proxy)

 # AUTHORS
RohanVB commented 7 years ago

@EverWinter23 Good job, it seemed to be a dependency issue. Can you please squash the extra commits? Also, Updates -> Update in the shortlog.

You can also remove the indent tab in the commit body and have a new line between the issue reference and commit body so it complies to: http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

Other than that, lgtm :)

EverWinter23 commented 7 years ago

Finally Done!!!

EverWinter23 commented 7 years ago

Just upgrading pip works.

RohanVB commented 7 years ago

ack 617d114141e1640e99744df8949ce69469226aac

meetmangukiya commented 7 years ago

@RohanVB any reason this is not merged ?

RohanVB commented 7 years ago

@meetmangukiya March 20, 2017 4:23 PM (tldr; only members of the coala maintainers' group are allowed to merge)