search

coala / coala-atom

A coala integration plugin for Atom
https://coala.io/
GNU Affero General Public License v3.0
20 stars 23 forks source link

main.coffee: Check for existence of .coafile #64

Closed EverWinter23 closed 6 years ago

EverWinter23 commented 7 years ago

Fixes https://github.com/coala/coala-atom/issues/60

satwikkansal commented 7 years ago 
Also resolves following atom dependecy issue:
Package libnotify64 not installed

This should be separate commit imo

satwikkansal commented 7 years ago

Also it'd be better to create a proper issues for the "NLTK data" and "libnotify64", and link them in the commit message so that it's easier to keep track of the changes later :)

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

EverWinter23 commented 7 years ago

do we really need that comment?

RohanVB commented 7 years ago

@EverWinter23 You have some extra commits in there (4 total). Rebase and drop/squash the extras as required please :)

EverWinter23 commented 7 years ago

Done.

RohanVB commented 7 years ago

Not quite :p Still 2 irrelevant commits there.

EverWinter23 commented 7 years ago

Should I squash them all into one?

EverWinter23 commented 7 years ago

From coala docs: What Makes a Good Commit A good commit is atomic. It should describe one change and not more.

3 commits for 3 changes.

RohanVB commented 7 years ago

My bad, I thought you picked up on 2 other commits (didn't notice the change was in the files)

EverWinter23 commented 7 years ago

So far so good, huh?

RohanVB commented 7 years ago

You already have the first commit merged here: https://github.com/coala/coala-atom/commit/76a79e1b1c3aef35935b4905f1d17a66ef0b1480 You can drop that one.

EverWinter23 commented 7 years ago

Yeah, didn't know about it. But, still have to install NLTK data.

EverWinter23 commented 7 years ago

Updated with changes.

EverWinter23 commented 7 years ago

how to apply the above patch?

satwikkansal commented 7 years ago

how to apply the above patch?

@EverWinter23 just run coala locally ;)

RohanVB commented 7 years ago

@satwikkansal check out this issue: https://github.com/coala/coala-bears/issues/1542 He'll have to fix it manually or use git apply. Running coala would delete the contents of the .md file

satwikkansal commented 7 years ago

@RohanVB Thanks. I don't think there's need to apply the patch as the PR doesn't include any modifications to README.md. Looks like this has to wait until the issues with Markdown Bear gets fixed, or we may have to merge it as is. IIRC, there have been a few PRs by jayvdb to fix the incompatibility issues with remark.

RohanVB commented 7 years ago

Looks like this has to wait until the issues with Markdown Bear gets fixed

The better option is applying the patch manually :)

merge it as is

Right now he has merge conflicts on the .md file

gitmate-bot commented 7 years ago

Comment on dd447a1902afe631dc48e43f38590bd6eef36a2d, file README.md, line 20.

The text does not comply to the set style.

MarkdownBear, severity NORMAL, section markdown.

The issue can be fixed by applying the following patch:

--- a/README.md
+++ b/README.md
@@ -17,8 +17,8 @@

 # AUTHORS

-*   Abdeali J Kothari - <mailto:abdealikothari@gmail.com>
-*   Lasse Schuirmann - <mailto:lasse.schuirmann@gmail.com>
+- Abdeali J Kothari - <mailto:abdealikothari@gmail.com>
+- Lasse Schuirmann - <mailto:lasse.schuirmann@gmail.com>

 If you have any questions regarding the plugin, don't hesitate
 to create an issue or send us an email.
gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

gitmate-bot commented 7 years ago

Hey! This wasn't updated since a while. Please check up on it!

sils commented 7 years ago

I rebased it for you and made gitmate and tests pass (force push!) but it doesn't seem to work :/

EverWinter23 commented 7 years ago

Thanks