search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
294 stars 580 forks source link

QuotesBear: Missing case #1176

Open Makman2 opened 7 years ago

Makman2 commented 7 years ago

Following case is not detected correctly: https://github.com/coala/coala/blob/Makman2/quotes-bear-fail/tests/processes/ProcessingTest.py#L204

On branch Makman2/quotes-bear-fail.

Locally it's not detected either:

mak@hp-elitebook-2540p:~/dev/coala (Makman2/quotes-bear-fail)$ coala
Executing section Default...
Executing section python...
Executing section autopep8...
Executing section linelength...
Executing section DOCS...
Executing section commit...
[ERROR][16:27:24] NLTK data missing, install by running following commands `python3 -m nltk.downloader punkt maxent_treebank_pos_tagger averaged_perceptron_tagger`
Executing section rst...

Section responsible for quotes is python. (See our coafile at coala/coala)

pareksha commented 6 years ago

@Makman2 I would like to take up this issue. Please assign me.

pareksha commented 6 years ago

@Makman2 it seems the problem is not with the QuotesBear. The problem is with the # ignore all statement. It is ignoring the line on which it is as well as the next line. Please see https://github.com/coala/coala/issues/5129

pareksha commented 6 years ago

@Makman2 in reference to my previous comment ( https://github.com/coala/coala-bears/issues/1176#issuecomment-362894458 ), this issue needs to be closed. Please assign me https://github.com/coala/coala/issues/5129 so that I can solve this.

Makman2 commented 6 years ago

I would like to keep this open as a special case where we want to be sure it works. I'll mark it blocked.

Makman2 commented 6 years ago

Blocked by https://github.com/coala/coala/issues/5129