coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
295 stars 580 forks source link

Superfluous capturing groups #1184

Closed jayvdb closed 7 years ago

jayvdb commented 7 years ago

coala-quickstart --ci is emitting lots of superfluous capturing group warnings

See https://travis-ci.org/jayvdb/Aurora/builds/185683597

WARNING:root:PyFlakesBear: Superfluous capturing group 'filename' used. Is this a typo? If not, consider removing the capturing group to improve coala's performance.

WARNING:root:MypyBear: Using unnecessary capturing groups affects the performance of coala. You should use '(?:<pattern>)' instead of '(<pattern>)' for your regex.

WARNING:root:MypyBear: Superfluous capturing group 'filename' used. Is this a typo? If not, consider removing the capturing group to improve coala's performance.

WARNING:root:PHPCodeSnifferBear: Using unnecessary capturing groups affects the performance of coala. You should use '(?:<pattern>)' instead of '(<pattern>)' for your regex.

WARNING:root:PHPCodeSnifferBear: Superfluous capturing group 'filename' used. Is this a typo? If not, consider removing the capturing group to improve coala's performance.

WARNING:root:GoErrCheckBear: Using unnecessary capturing groups affects the performance of coala. You should use '(?:<pattern>)' instead of '(<pattern>)' for your regex.

WARNING:root:SpellCheckBear: Superfluous capturing group 'filename' used. Is this a typo? If not, consider removing the capturing group to improve coala's performance.

WARNING:root:SCSSLintBear: Using unnecessary capturing groups affects the performance of coala. You should use '(?:<pattern>)' instead of '(<pattern>)' for your regex.
Makman2 commented 7 years ago

Let me fix that quickly, we should get rid of those warnings^^

jayvdb commented 7 years ago

Another example of it appearing; https://travis-ci.org/fossasia/gci16.fossasia.org/builds/186540995#L458

jayvdb commented 7 years ago

And in our docs : https://travis-ci.org/coala/coala-bears/jobs/186609019#L4049