search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
295 stars 580 forks source link

Evaluate using Python imagesize for ImageDimensionBear #1313

Open coala-bot opened 7 years ago

coala-bot commented 7 years ago

https://pypi.python.org/pypi/imagesize is a dependency of Sphinx, so it is already part of our dependencies (via rstcheck). If it works as well/fast as the Ruby implementation, we should use that to reduce our dependencies.

Opened via gitter by @jayvdb

jayvdb commented 7 years ago

cc: @rhemon , maybe you want to try this after you've finished https://github.com/coala/coala-bears/pull/1288 for https://github.com/coala/coala-bears/issues/1260

Makman2 commented 7 years ago

we would still need imagesize as an dependency though, so things don't break if sphinx decides (whyever) to use something else^^

jayvdb commented 7 years ago

@Makman2 , maybe I wasnt clear ... using Python package imagesize would remove the need for Ruby gem img_checker.

Makman2 commented 7 years ago

Ah okay cool :D

jayvdb commented 7 years ago

This is obviously blocked by https://github.com/coala/coala-bears/issues/1260 , or will need to be done as part of that enhancement (and it is blocked too).