search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
295 stars 580 forks source link

ScalaLintBear: Add support for scala 2.11 #1366

Open gaocegege opened 7 years ago

gaocegege commented 7 years ago

We could support scala 2.11 based on scalastyle-2.11.

gaocegege commented 7 years ago

@jayvdb Hi, could we add a option scala_version= 2.10 | 2.11 to solve this issue?

jayvdb commented 7 years ago

Firstly, this bear needs to move to using MavenRequirement, similar to https://github.com/coala/coala-bears/issues/1250 .

The user needs to be able to choose the jar, or choose the scala version (and then the bear finds the correct jar)

gaocegege commented 7 years ago

Got it.

Shade5 commented 7 years ago

Hey, still working on this?

gaocegege commented 7 years ago

I think the issue is blocked. See https://github.com/coala/coala-bears/issues/1250 for more info :)

Feel free to have a try.

Makman2 commented 7 years ago

not necessarily imo :)

gaocegege commented 7 years ago

hmm I have no idea how to find the binary under maven.

@shaan15 You can take this issue :)

Shade5 commented 7 years ago

Can I take over?

jayvdb commented 7 years ago

This is probably be solved by https://github.com/coala/coala-bears/issues/1654 , but that is a very specific solution. I've assigned it to @Shade5 .