search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
296 stars 580 forks source link

radon depends on flake8 #1388

Open jayvdb opened 7 years ago

jayvdb commented 7 years ago

See https://github.com/coala/coala-bears/issues/1228#issuecomment-270051284 for background on why this is a problem.

jayvdb commented 7 years ago

Mostly note to self: A non-upstream approach might be create a dummy (empty) flake8 package with an appropriate version to workaround the dependency requirements. In a virtualenv, this would be fine. However in a real environment, it would conflict with, and break, existing flake8, so a lot of care would be needed to ensure that it isnt possible for setuptools or pip to upgrade a proper flake8 with our dummy flake8 package (a magic envvar might be an option).

jack17529 commented 7 years ago

I am already working on vulture integration with flake8 maybe I can help you with it.

jayvdb commented 5 years ago

The temporary solution in 00103fed involved pinning radon to 1.4.0 .

radon is now 2.4.0

radon 1.4.0 is https://github.com/rubik/radon/tree/c1a100e13d , depends on colorama>=0.3,<0.4 , which is now becoming a big problem as many other packages depend on colorama >= 0.4.

jayvdb commented 5 years ago

radon current setup.py still depends on 'colorama>=0.3,<0.4', 'flake8-polyfill',

So both the flake8 problem and the colorama problem exist. Upgrading the dependency will not solve anything.

jayvdb commented 5 years ago

Example error https://files.gitter.im/coala/gci/SWIf/image.png