search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
294 stars 580 forks source link

FilenameBear: Move code #1846

Open Makman2 opened 7 years ago

Makman2 commented 7 years ago

https://github.com/coala/coala-bears/blob/master/bears/general/FilenameBear.py#L74-L75 should be moved to https://github.com/coala/coala-bears/blob/master/bears/general/FilenameBear.py#L49. The condition comes way too late and can be executed earlier^^

This is the relevant code (in case the links do not point to the correct locations any more):

if ignore_uppercase_filenames and filename_without_extension.isupper():
    return

should be moved after this statement:

filename_without_extension, extension = os.path.splitext(tail)
alexkassil commented 7 years ago

I will take this on!

yash-nisar commented 7 years ago

Please go through https://coala.io/newcomer and assign the issue to yourself on our gitter channel via cobot.

pranavmodx commented 5 years ago

Looks like @naivedyabansal is not working on this issue anymore. Can I take this up as my first newcomer issue?