search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
295 stars 580 forks source link

Add Pycycle bear #2411

Open li-boxuan opened 6 years ago

li-boxuan commented 6 years ago

To find and fix circular imports in python projects https://github.com/bndr/pycycle

palash25 commented 6 years ago

Do you really think that it would be a good idea to use this https://github.com/bndr/pycycle ? It was only developed for 2 months and has been unmaintained for about a year. Maybe implementing a native bear similar to pycycle would be a better idea. What do you think @li-boxuan ?

jayvdb commented 6 years ago

They have test cases, and CI.

If it works, we can add it.

Better work with them, rather than duplicate effort.

But maybe bandit already does this, or plans to do it?

The main question is does it have any false positives on coala or -bears or -quickstart repos?

If so, we'd need to raise those upstream to get fixed before we could attempt it.

jayvdb commented 5 years ago

This issue reserved for Google Code-in task 5890150253985792.

kiy4h commented 5 years ago

The main question is does it have any false positives on coala or -bears or -quickstart repos?

Apparently, no. I ran pycycle --here in the repositories coala, coala-bears, and coala-quickstart, and there were no cycles found.

(I was using a virtual environment when running the command)