search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
295 stars 580 forks source link

GitCommitBear: Check for WIP: shortlog #2471

Open virresh opened 6 years ago

virresh commented 6 years ago

Currently the bear only yields a result in case the shortlog starts with "[wip] " It should also check for "WIP: "

rohanrk commented 6 years ago

May I be assigned to this issue?

jayvdb commented 6 years ago

@rohanrk , @virresh , it looks like the code was already checking for WIP: , but in a slighly obscure way.

And it wasnt properly supported, as there was another related bug with relatation to imperative tense on WIP: patches , and the PR fixes that other bug.

rohanrk commented 6 years ago

When I tested the bear, it failed WIP checks when I had WIP:

jayvdb commented 6 years ago

I think it failed the imperative checks, not the wip checks. If so, it was possible to configure GitCommitBear to use WIP: , but only if the imperative checks were disabled.

rohanrk commented 6 years ago

Yes. this is because the imperative check modified the shortlog and the WIP check occurred after the imperative check. Was there another issue for the other bug you were talking about?