search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
295 stars 580 forks source link

Use gometalinter installer for all golang syntax checkers #2596

Open jayvdb opened 6 years ago

jayvdb commented 6 years ago

Most of the go linters are installed using gometalinter which keeps a versioned copy of the dependencies.

However we still have the manual install of 

go get -u sourcegraph.com/sqs/goreturns
go get -u github.com/BurntSushi/toml/cmd/tomlv

tomlv isnt a linter of go language, so it wont be suitable for gometalinter, but it is less likely to break with go versions because it doesnt check go syntax which changes with each golang version and doesnt depend on golang syntax parsers which improves (aka breaks) with each golang version.

goreturns could be proposed to gometalinter, allowing us to maintain all go syntax linters via gometalinter

(See https://github.com/coala/coala-bears/pull/2599 for removal of unnecessary go gets)

jayvdb commented 6 years ago

Another go bear to potentially add to gometalinter https://github.com/coala/coala-bears/issues/1649

jayvdb commented 5 years ago

goreturns proposed upstream at https://github.com/alecthomas/gometalinter/issues/568