coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
294 stars 580 forks source link

PySafetyBear.py: Add proxy positional argument #2860

Closed Naveenaidu closed 5 years ago

Naveenaidu commented 5 years ago

The newer Safety package(v1.8.5) now adds the functionality to support proxies which the Requests package of Python uses.

The above functionality by Safety has been provided by adding an extra positional argument called proxy in the saftey.check() function. This caused the TypeError in the previous version of Safety,due to mismatch of number of positional argument

Closes https://github.com/coala/coala-bears/issues/2857

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

jayvdb commented 5 years ago

ack https://github.com/coala/coala-bears/pull/2860/commits/4a1ccfb2be7979b17c794e1bfb5c46ef2df0b155

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: