Add support for yapf>=0.21.0<0.27.0 and fix filename in .ci/generate_bear_metadata.py

coala / coala-bears

Bears for coala

https://coala.io/

GNU Affero General Public License v3.0

294 stars 580 forks source link

Add support for yapf>=0.21.0<0.27.0 and fix filename in .ci/generate_bear_metadata.py #2880

Closed areebbeigh closed 5 years ago

areebbeigh commented 5 years ago

Modify test_allow_multiline_lambdas to be version specific.

Closes https://github.com/coala/coala-bears/issues/2873

Change "overrides" filename from package-manager-requirements.yaml to pm-requirements.yaml

Fixes https://github.com/coala/coala-bears/issues/2936

Checklist

[x] I read the commit guidelines and I've followed them.
[x] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!

areebbeigh commented 5 years ago

Needs a rebase

Done. Heads up: Merge conflict in bear-requirements.yaml was resolved by hand (merge both incoming changes). Please let me know if I'm supposed to re-generate it.

jayvdb commented 5 years ago

Refetch master bear-requirements.yaml

Use .ci/generate_bear_metadata.py , and then run moban.

areebbeigh commented 5 years ago

.ci/generate_bear_metadata.py

I'm running into:

Warning: Both package-manager-requirements.yaml and /home/areebbeigh/.cache/moban/repos/mobans/package-manager-requirements.yaml does not exist

and I suspect this is because running ci/generate_bear_metadata.py sets overrides: package-manager-requirements.yaml whereas it should be overrides: pm-requirements.yaml.

New issue? Although this is probably just a change in https://github.com/coala/coala-bears/blob/afb068b11a634b9f869f5385337628284a42bab3/.ci/generate_bear_metadata.py#L461

jayvdb commented 5 years ago

Yup; new issue. That is a bug in my PR.

jayvdb commented 5 years ago

You can add the fix to this PR as a separate commit.

areebbeigh commented 5 years ago

You can add the fix to this PR as a separate commit.

Done.

jayvdb commented 5 years ago

Sorry ; wrong button press.

@areebbeigh , this needs another rebase, but please also revise your commit messages to follow the coala commit guidelines. specifically the first line should start with a filename of the most important file in the commit which is being modified (usually not a file which is generated).

jayvdb commented 5 years ago

I'm going to merge this despite it failing due to https://github.com/coala/coala-bears/issues/2937 , which I'll fix after this is merged