search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
295 stars 580 forks source link

Create choco package for luacheck #2918

Open jayvdb opened 5 years ago

jayvdb commented 5 years ago

Due to problems regarding https://gitlab.com/coala/package_manager/issues/260 , the easiest approach for coala-bears is to create a package for 32bit luacheck, which can then be run in the 64 bit jobs.

This could be done by adding it to the choco lua package

https://github.com/rjpcomputing/luaforwindows/issues/126

Or creating a new choco package which depends on either the lua or luarocks packages.

jayvdb commented 5 years ago

If luacheck doesnt need compiling, it might be possible to install https://chocolatey.org/packages/lua (which includes dependency LuaFileSystem) , and use its luarocks to install luacheck. I thought I tried that and it failed, but I dont recall.

What I think we should avoid is the 64 bit builds switching to the 32 bit compilers to do 32 bit stuff pre-installing, and then switching back to 64 bit. It isnt too difficult, but the build will get messy, and it can be avoided by creating pre-compiled choco packages, which can be installed onto the VM when the compiler in either 32bit or 64bit mode.

https://github.com/mpeterv/luacheck#windows-binary-download already has a 64 bit compilation which just needs wrapping into a choco package.