search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
294 stars 580 forks source link

lxml 4.4.0 dropped support for Python 3.4 #2940

Closed abhishalya closed 5 years ago

abhishalya commented 5 years ago

Need to cap below 4.4.0.

jayvdb commented 5 years ago

This should be done like https://github.com/moremoban/moban/commit/5e895b6a9e3a7b06c3cbd3ea651b197990366c33 , so that newer versions of Python are not effected.

Also the lxml dependency is special, and is managed in the .ci/deps.python-packages.ps1 for Windows so that it is installed with special flags. That fix needs to be done in mobans repo, as lxml is important in all repos.

jayvdb commented 5 years ago

Where is this breaking a build ?

abhishalya commented 5 years ago

I saw it here. Now it seems we have even more build failures.

jayvdb commented 5 years ago

Also triggered at https://github.com/coala/coala/pull/6054 . Annoying.

jayvdb commented 5 years ago

Temporary solution in https://gitlab.com/coala/mobans/merge_requests/135 , deploying to coala and coala-quickstart.

jayvdb commented 5 years ago

Cherry-picked https://github.com/abhishalya/coala-bears/commit/bf3b7a2ef692b0cc3665650fbb20072fd2870c79 onto https://github.com/coala/coala-bears/pull/2942 . Note I needed to also update the pin in bear-requirements.txt and adjusted the commit message a little .

Feel free to create a PR with it and ill rebase on top of your PR. Otherwise, your commit will show it was amended by me. Up to you

jayvdb commented 5 years ago

The reason it was needed, despite the pre-install, is that tox on Unix is not using 'site-packages' so versions installed outside the tox venv are not visible inside, so tox tries to use an old pip to install lxml, and fails. https://travis-ci.org/jayvdb/coala-bears/jobs/567832173

This should be done like moremoban/moban@5e895b6 , so that newer versions of Python are not effected.

The minreqs templates should be implemented in all our repos, and will very likely reveal that our minimum versions are wrong.

The new travis templates do support this, but we should start with the gitlab-ci templates for the gitlab repos, as their minimums effect coala core and coala bears.

Also the lxml dependency is special, and is managed in the .ci/deps.python-packages.ps1 for Windows so that it is installed with special flags. That fix needs to be done in mobans repo, as lxml is important in all repos.

No change is necessary in mobans, as the currently logic in .ci/deps.python-packages.ps1 uses the latest pip and --prefer-binary picks the latest binary version for py34, which happens to be the older version because none are built for py34.

jayvdb commented 5 years ago

We currently dont have support for dependencies for per-Python-version ('constraints'), and I suspect that is going to take a while, so we can revisit this problem whenever we find that <4.4.0 is causing some other bug.

abhishalya commented 5 years ago

Cherry-picked abhishalya@bf3b7a2 onto #2942 . Note I needed to also update the pin in bear-requirements.txt and adjusted the commit message a little .

No problem :+1: