clang-format integration

sils commented 8 years ago

Do we want that? How does it relate to just GNU format?

status/needs design

gitmate-bot commented 8 years ago

Thanks for reporting this issue!

Your aid is required, fellow coalaian. Help us triage and solving this issue!

CC @sils1297, @AbdealiJK

jmc-88 commented 7 years ago

I'm assuming you mean GNU indent here, as I'm unaware of what GNU format is and couldn't find any pointers for it:

Yes, you want that. GNU indent is targeted at C source code (from the manual: "indent: Indent and Format C Program Source"), while clang-format supports several different languages.
GNU indent hasn't seen a release in about 8 years (check the timestamps: mirror link), while clang-format is under active development.

It should hopefully be trivial to write a bear that wraps around the clang-format binary, with the following caveats:

the tool name should be configurable (for instance, Debian systems allow parallel installation of multiple clang/LLVM versions, so the binaries might be suffixed with the relevant clang release version, such as clang-format-3.8)
it doesn't make much sense to provide knobs for individual style options (there's too many): the only sensible option is to accept a predefined style guide to follow (e.g.: "google") or a filename to pass to the -style flag.

sils commented 7 years ago

@jmc-88 thanks a lot for the analysis! Removing needs design as it's crystal clear why and what we want IMO.

With cEP-0005 we will actually want to turn most of those options into aspects long term even though it will be a lot of work.

StanleySweet commented 4 years ago

I created a version here, will probably make a PR at some point https://code.wildfiregames.com/D2490

coala / coala-bears