search

coala / coala-bears

Bears for coala
https://coala.io/
GNU Affero General Public License v3.0
295 stars 580 forks source link

New FilesExistBear for checking if project files exist #527

Open underyx opened 8 years ago

underyx commented 8 years ago

I just copied over an old .coafile to a new project. It would have been nice if I could've had something like

bears = FilesExistBear
required_files = README*, LICENSE*, CONTRIBUTING*

and then coala could've complained that I forgot to put a license in my new project. It could also have opinionated defaults, for people who don't even know that they should have for instance a LICENSE and therefore turn to coala for advice on what files are missing.

Maybe we could also have something like required_file_presets = python, git, github, circleci, which would automatically require setup.py, .gitignore, .github/ISSUE_TEMPLATE.md, circle.yml, etc.

This could also catch errors like this one https://github.com/apache/incubator-airflow/commit/52d9b33ff3b1cb970ceb56b920c444d0edb33b9f.

area/lintbears type/feature

gitmate-bot commented 8 years ago

Thanks for reporting this issue!

Your aid is required, fellow coalaian. Help us triage and solving this issue!

CC @sils1297, @AbdealiJK

sils commented 8 years ago

@underyx interested in helping out here?

underyx commented 8 years ago

@sils1297 one day, maybe :D

madhur-tandon commented 7 years ago

What difficulty level is this ? (low or medium) ?

sils commented 7 years ago

low-ish. You'll have to work out what's the best thing to write here before writing it ;)

madhur-tandon commented 7 years ago

@sils Can I be assigned this instead of https://github.com/coala/coala-bears/issues/836 ? This seems more interesting and doable to me as of now.

sils commented 7 years ago

ok

yash-nisar commented 7 years ago

Are you still working on this @amrandahvur ?

madhur-tandon commented 7 years ago

I am busy with my college projects as of now. Go ahead and take it up :)

On 26-Jan-2017 5:57 PM, "Yash Nisar" notifications@github.com wrote:

Are you still working on this @amrandahvur https://github.com/amrandahvur ?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/coala/coala-bears/issues/527#issuecomment-275376858, or mute the thread https://github.com/notifications/unsubscribe-auth/ATPTq-OuVwsH2j-iEuBw8DFzqnje92aAks5rWJEngaJpZM4I2Z07 .

jayvdb commented 7 years ago

One part of this request is also solvable with https://github.com/coala/coala-bears/pull/1442

Another way to solve this, and IMO a more appropriate way, is to have a .coafile section which lints those files with explicit mentions in files =, and an error if any explicit filename (i.e. no globs) is not found.

bkhanale commented 5 years ago

This issue is reserved under the GSoC project Improve Generic Bear Quality.