.coafile: Add Python blank line formatting rules

coala / coala-bears

Bears for coala

https://coala.io/

GNU Affero General Public License v3.0

294 stars 580 forks source link

.coafile: Add Python blank line formatting rules #620

Open sils opened 8 years ago

sils commented 8 years ago

The following was needed here:

No newline after class ... before the first def
One newline after a docstring after class ... before the def

gitmate-bot commented 8 years ago

Thanks for reporting this issue! A coalaian will look at it soon.

sils commented 8 years ago

wrap https://github.com/hhatto/autopep8#features to proper settings in the bear

@Asnelchristian interested?

kriti21 commented 6 years ago

Does this need configuring of all the bears available for python ? @sils @Makman2

Makman2 commented 6 years ago

Choose one where those new features would fit best @kriti21 :)

kriti21 commented 6 years ago

Please assign this issue to me.

kriti21 commented 6 years ago

Please review my above PR @sils

sils commented 6 years ago

Sorry, I don't have the time to review this, if you want reviews, perform reviews for others so they help you out as well.

Sincerely,

Lasse Schuirmann

lasse@schuirmann.net Founder of http://coala.io/, http://viperdev.io/ and http://gitmate.io/

On 12 February 2018 at 09:07, Kriti Rohilla notifications@github.com wrote:

Please review my above PR @sils https://github.com/sils

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coala/coala-bears/issues/620#issuecomment-364851535, or mute the thread https://github.com/notifications/unsubscribe-auth/AFc6KGj1vxLmfTPX6zcp0LLFuvg4jtx8ks5tT_FKgaJpZM4JTiWb .

jayvdb commented 6 years ago

I believe the correct way to do this is require all classes have a docstring, and I believe that then pycodestyle and pydocstyle will provide what is needed, with a little configuration.

Our generic bear for docstyles is woefully incapable of doing this, but that is one possible way forward with this issue. Several enhancements in core would be needed to make it possible.

jayvdb commented 6 years ago

Assigning @kriti21 as they have a PR which references this issue. With some .coafile additions, that PR could be enough to resolve most of this issue, and we can reconsider the rest.

jayvdb commented 6 years ago

Closed the associated PR as it wasnt going anywhere.

AkshJain99 commented 6 years ago

What actually we need to do to solve this issue???