README.rst: Added screenshot of the demo page

coala / coala-html

Interactive website generator using results from coala

GNU Affero General Public License v3.0

17 stars 40 forks source link

README.rst: Added screenshot of the demo page #101

Closed marian-ald closed 7 years ago

gitmate-bot commented 7 years ago

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
- I have followed the guidelines for the commit shortlog.
- I have followed the guidelines for the commit body.
- I have included the issue URL.
- I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

whythefyouflying commented 7 years ago

Hello @marian-ald.

I think that is not what was meant by screenshot of the demo page. The page is located at http://coala.github.io/coala-html/#/

You should also include a Fixes/Closes message in your commit message. I would also change from 'Added' to 'Add' in your commit shortlog.

marian-ald commented 7 years ago

So, have I to do it for the link above? http://coala.github.io/coala-html/#/

marian-ald commented 7 years ago

Unfortunately I don't know what do you mean by Fixes / Closes

aptrishu commented 7 years ago

Go to https://coala.io/commit . @marian-ald

Nosferatul commented 7 years ago

Now the screenshot it's fine, squash your commits and add Closes <link_to_your_issue> in the commit message. use git commit --amend change your commit message and push again!

whythefyouflying commented 7 years ago

@marian-ald okay, you still need to squash your commits. to do that, run git rebase -i HEAD~3, that should try to rebase latest three commits from your branch. after you do it, you should see, something like this

pick u59gw6 Added demo of...
pick 725529 Add demo of...
pick 9hoeh7 Add demo of...

<bunch of comments on usage here>

In the usage comments you can see an 'squash' option.

Replace two of these 'pick' with 'squash' and save the file. Then you will end up editing another file. This is the commit message one. I would make it like this

README.rst: Add screenshot of the demo page.

Closes <link to issue here>

Then save and force push.

Mixih commented 7 years ago

@marian-ald to remove the files that aren't yours in this pull see: http://stackoverflow.com/questions/18357511/git-remove-commited-file-after-push

gitmate-bot commented 7 years ago

Comment on 0cebad57b4179596b96e458950eff0e11bf3ccc7, file coalahtml/_coalahtml/app/styles/files.css, line 40.

Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section css.

gitmate-bot commented 7 years ago

Comment on 0cebad57b4179596b96e458950eff0e11bf3ccc7, file coalahtml/_coalahtml/app/styles/files.css, line 39.

Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section css.

gitmate-bot commented 7 years ago

Comment on 27ca7d354eb4e1d81915e7695ddfaa693a721f21, file coalahtml/_coalahtml/app/styles/files.css, line 40.

Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section css.

gitmate-bot commented 7 years ago

Comment on 27ca7d354eb4e1d81915e7695ddfaa693a721f21, file coalahtml/_coalahtml/app/styles/files.css, line 39.

Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section css.

marian-ald commented 7 years ago

I followed those steps. I think it should be ok, but still have those commits on my page :/...

aptrishu commented 7 years ago

Ask us on the channel. https://gitter.im/coala/coala someone will help you.

jayvdb commented 7 years ago

Unfortunately, you did not follow the Git basics. This Pull Request (PR) is using your "master" branch, which means you did not create a new branch.

Please redo your changes, following the Git Basics guide, and submit a new PR.