coala / coala-html

Interactive website generator using results from coala
GNU Affero General Public License v3.0
17 stars 40 forks source link

README.rst: Fix getting involved link #138

Closed prashant0598 closed 7 years ago

prashant0598 commented 7 years ago

Fix getting involved link This ensures that link pointing to "Getting involved information" page is correct. Closes #128

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

prnvdixit commented 7 years ago

@prashant0598 Please finish the tasks that are already assigned to you - https://github.com/coala/corobo/issues/299, https://github.com/coala/coala/issues/4648. Also, these all are difficulty/newcomer tasks - Including this one, this sums it all to 3 newcomer tasks for you. I would recommend to focus on these issues first and then move to higher difficulty issues and leave the newcomer issues for someone who is actually newcomer.

Also, you have made a new PR to the same issue after a long inactivity to the older PR - It is never required. You should never make more than one PR to an issue.

Please either unassign yourself from other issues or finish them. In case, any help is needed, you can ask it right away on gitter channel - Someone would be around to help you. :)

RaiVaibhav commented 7 years ago

I am making it wip there are 3 PR ,it don't need to review, it need to either gets close @prashant0598 Its a request if you feel you can solve any of one PR totally then close other two after that you can remove wip and add label pending,till then I am labeling it wip

prashant0598 commented 7 years ago

@prnvdixit coala/coala#4648 files could not be found and coala/corobo#299, has some image problem so i took up this issue and i actually deleted the branch of this duplicate issue so i made a new pr i was inactive due to exams and will now unassign myself from other issues

RaiVaibhav commented 7 years ago

@prashant0598 then atleast get unassigned from those maintainers/developers will take care of that issues, close your PR also

prashant0598 commented 7 years ago

@RaiVaibhav Done it :+1:

RaiVaibhav commented 7 years ago

Its a request, next time please assign issue if you feel you can complete or if you think something unclear in issue then please report.

prnvdixit commented 7 years ago

@prashant0598 IMO you needn't unassign yourself from the squirrel image issue - Someone left a review there already, atleast try what he suggested and see if it works 😉

prnvdixit commented 7 years ago

Also, I am not quite sure of this but - You mightn't have deleted your branch yet as it is still visible in the duplicate PR i.e. "prashant0598-patch-1". In my experience, deletion might have resulted in something like "unknown-repository"...

prashant0598 commented 7 years ago

@prnvdixit @yashovardhanagrawal Pls review as i hv done required changes

yashovardhan commented 7 years ago

@prashant0598 please insert a line break between the description and Closes #128 as I had suggested

prashant0598 commented 7 years ago

@jayvdb Pls review

yashovardhan commented 7 years ago

ack https://github.com/coala/coala-html/pull/138/commits/f81af086e5d6442ae792db3cd5dc3695a2908253

jayvdb commented 7 years ago

@rultor merge

rultor commented 7 years ago

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 7 years ago

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)