Updated Logo and Fixed broken link in README.md (Issue #151 , #156)

aitikgupta commented 5 years ago

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

[ ] I read the commit guidelines and I've followed them.
[ ] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out of the review queue.

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @aitikgupta, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

npm test

``` > @ test /home/travis/build/coala/coala-html > karma start --single-run --browsers PhantomJS 15 10 2019 21:30:19.599:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/ 15 10 2019 21:30:19.601:INFO [launcher]: Launching browser PhantomJS with concurrency 1 15 10 2019 21:30:19.606:INFO [launcher]: Starting browser PhantomJS 15 10 2019 21:30:20.542:INFO [PhantomJS 2.1.1 (Linux 0.0.0)]: Connected on socket LVqm-lnOHVlY-H2bAAAA with id 82964916 PhantomJS 2.1.1 (Linux 0.0.0): Executed 0 of 26 SUCCESS (0 secs / 0 secs) LOG: 'true /home/Desktop/test.py' PhantomJS 2.1.1 (Linux 0.0.0): Executed 0 of 26 SUCCESS (0 secs / 0 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 1 of 26 SUCCESS (0 secs / 0 secs) LOG: 'true /home/Desktop/test.py' PhantomJS 2.1.1 (Linux 0.0.0): Executed 1 of 26 SUCCESS (0 secs / 0 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 2 of 26 SUCCESS (0 secs / 0 secs) LOG: 'true /home/Desktop/test.py' PhantomJS 2.1.1 (Linux 0.0.0): Executed 2 of 26 SUCCESS (0 secs / 0 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 3 of 26 SUCCESS (0 secs / 0 secs) LOG: 'true /home/Desktop/test.py' PhantomJS 2.1.1 (Linux 0.0.0): Executed 3 of 26 SUCCESS (0 secs / 0 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 4 of 26 SUCCESS (0 secs / 0.001 secs) LOG: 'true /home/Desktop/test.py' PhantomJS 2.1.1 (Linux 0.0.0): Executed 4 of 26 SUCCESS (0 secs / 0.001 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 5 of 26 SUCCESS (0 secs / 0.002 secs) LOG: 'true /home/Desktop/test.py' PhantomJS 2.1.1 (Linux 0.0.0): Executed 5 of 26 SUCCESS (0 secs / 0.002 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 6 of 26 SUCCESS (0 secs / 0.003 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 7 of 26 SUCCESS (0 secs / 0.003 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 8 of 26 SUCCESS (0 secs / 0.003 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 9 of 26 SUCCESS (0 secs / 0.003 secs) PhantomJS 2.1.1 (Linux 0.0.0) MainCtrl parseCoalaProject() "before each" hook: WorkFn for "test result count" FAILED Unexpected request: GET app/views/main.html No more request expected $httpBackend@node_modules/angular-mocks/angular-mocks.js:1617:78 sendReq@coalahtml/_coalahtml/bower_components/angular/angular.js:13288:21 serverRequest@coalahtml/_coalahtml/bower_components/angular/angular.js:13029:23 processQueue@coalahtml/_coalahtml/bower_components/angular/angular.js:17945:39 coalahtml/_coalahtml/bower_components/angular/angular.js:17993:39 $digest@coalahtml/_coalahtml/bower_components/angular/angular.js:19112:17 flush@node_modules/angular-mocks/angular-mocks.js:2035:45 tests/specs/controllers/MainCtrlSpec.js:79:31 invoke@coalahtml/_coalahtml/bower_components/angular/angular.js:5141:24 WorkFn@node_modules/angular-mocks/angular-mocks.js:3459:26 inject@node_modules/angular-mocks/angular-mocks.js:3426:28 tests/specs/controllers/MainCtrlSpec.js:65:26 tests/specs/controllers/MainCtrlSpec.js:62:13 global code@tests/specs/controllers/MainCtrlSpec.js:3:9 PhantomJS 2.1.1 (Linux 0.0.0): Executed 10 of 26 (1 FAILED) (0 secs / 0.015 secs) PhantomJS 2.1.1 (Linux 0.0.0) MainCtrl parseCoalaProject() "after each" hook for "test result count" FAILED [$rootScope:inprog] $digest already in progress https://errors.angularjs.org/1.7.8/$rootScope/inprog?p0=%24digest beginPhase@coalahtml/_coalahtml/bower_components/angular/angular.js:19758:88 $digest@coalahtml/_coalahtml/bower_components/angular/angular.js:19088:19 verifyNoOutstandingExpectation@node_modules/angular-mocks/angular-mocks.js:2070:45 tests/specs/controllers/MainCtrlSpec.js:87:54 PhantomJS 2.1.1 (Linux 0.0.0): Executed 11 of 26 (2 FAILED) (0 secs / 0.016 secs) PhantomJS 2.1.1 (Linux 0.0.0) MainCtrl search "before each" hook: WorkFn for "test search matching" FAILED Unexpected request: GET app/views/main.html No more request expected $httpBackend@node_modules/angular-mocks/angular-mocks.js:1617:78 sendReq@coalahtml/_coalahtml/bower_components/angular/angular.js:13288:21 serverRequest@coalahtml/_coalahtml/bower_components/angular/angular.js:13029:23 processQueue@coalahtml/_coalahtml/bower_components/angular/angular.js:17945:39 coalahtml/_coalahtml/bower_components/angular/angular.js:17993:39 $digest@coalahtml/_coalahtml/bower_components/angular/angular.js:19112:17 flush@node_modules/angular-mocks/angular-mocks.js:2035:45 tests/specs/controllers/MainCtrlSpec.js:120:31 invoke@coalahtml/_coalahtml/bower_components/angular/angular.js:5141:24 WorkFn@node_modules/angular-mocks/angular-mocks.js:3459:26 inject@node_modules/angular-mocks/angular-mocks.js:3426:28 tests/specs/controllers/MainCtrlSpec.js:106:26 tests/specs/controllers/MainCtrlSpec.js:103:13 global code@tests/specs/controllers/MainCtrlSpec.js:3:9 PhantomJS 2.1.1 (Linux 0.0.0): Executed 12 of 26 (3 FAILED) (0 secs / 0.023 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 13 of 26 (3 FAILED) (0 secs / 0.024 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 14 of 26 (3 FAILED) (0 secs / 0.024 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 15 of 26 (3 FAILED) (0 secs / 0.024 secs) PhantomJS 2.1.1 (Linux 0.0.0) BsNavActive Directive activates item FAILED Unexpected request: GET app/views/main.html No more request expected $httpBackend@node_modules/angular-mocks/angular-mocks.js:1617:78 sendReq@coalahtml/_coalahtml/bower_components/angular/angular.js:13288:21 serverRequest@coalahtml/_coalahtml/bower_components/angular/angular.js:13029:23 processQueue@coalahtml/_coalahtml/bower_components/angular/angular.js:17945:39 coalahtml/_coalahtml/bower_components/angular/angular.js:17993:39 $digest@coalahtml/_coalahtml/bower_components/angular/angular.js:19112:17 tests/specs/directives/BsNavActiveDirectiveSpec.js:42:18 PhantomJS 2.1.1 (Linux 0.0.0): Executed 16 of 26 (4 FAILED) (0 secs / 0.026 secs) PhantomJS 2.1.1 (Linux 0.0.0) BsNavActive Directive "after each" hook for "activates item" FAILED [$rootScope:inprog] $digest already in progress https://errors.angularjs.org/1.7.8/$rootScope/inprog?p0=%24digest beginPhase@coalahtml/_coalahtml/bower_components/angular/angular.js:19758:88 $digest@coalahtml/_coalahtml/bower_components/angular/angular.js:19088:19 flush@node_modules/angular-mocks/angular-mocks.js:2035:45 tests/specs/directives/BsNavActiveDirectiveSpec.js:36:23 PhantomJS 2.1.1 (Linux 0.0.0): Executed 17 of 26 (5 FAILED) (0 secs / 0.026 secs) PhantomJS 2.1.1 (Linux 0.0.0) Prettyprint Directive runs pretty print FAILED Unexpected request: GET app/views/main.html No more request expected $httpBackend@node_modules/angular-mocks/angular-mocks.js:1617:78 sendReq@coalahtml/_coalahtml/bower_components/angular/angular.js:13288:21 serverRequest@coalahtml/_coalahtml/bower_components/angular/angular.js:13029:23 processQueue@coalahtml/_coalahtml/bower_components/angular/angular.js:17945:39 coalahtml/_coalahtml/bower_components/angular/angular.js:17993:39 $digest@coalahtml/_coalahtml/bower_components/angular/angular.js:19112:17 tests/specs/directives/PrettyprintDirectiveSpec.js:50:18 PhantomJS 2.1.1 (Linux 0.0.0): Executed 18 of 26 (6 FAILED) (0 secs / 0.036 secs) PhantomJS 2.1.1 (Linux 0.0.0) Prettyprint Directive "after each" hook for "runs pretty print" FAILED [$rootScope:inprog] $digest already in progress https://errors.angularjs.org/1.7.8/$rootScope/inprog?p0=%24digest beginPhase@coalahtml/_coalahtml/bower_components/angular/angular.js:19758:88 $digest@coalahtml/_coalahtml/bower_components/angular/angular.js:19088:19 flush@node_modules/angular-mocks/angular-mocks.js:2035:45 tests/specs/directives/PrettyprintDirectiveSpec.js:44:23 PhantomJS 2.1.1 (Linux 0.0.0): Executed 19 of 26 (7 FAILED) (0 secs / 0.036 secs) PhantomJS 2.1.1 (Linux 0.0.0) TableRowLinks Directive adds link to row FAILED Unexpected request: GET app/views/main.html No more request expected $httpBackend@node_modules/angular-mocks/angular-mocks.js:1617:78 sendReq@coalahtml/_coalahtml/bower_components/angular/angular.js:13288:21 serverRequest@coalahtml/_coalahtml/bower_components/angular/angular.js:13029:23 processQueue@coalahtml/_coalahtml/bower_components/angular/angular.js:17945:39 coalahtml/_coalahtml/bower_components/angular/angular.js:17993:39 $digest@coalahtml/_coalahtml/bower_components/angular/angular.js:19112:17 tests/specs/directives/TableRowLinksDirectiveSpec.js:42:18 PhantomJS 2.1.1 (Linux 0.0.0): Executed 20 of 26 (8 FAILED) (0 secs / 0.038 secs) PhantomJS 2.1.1 (Linux 0.0.0) TableRowLinks Directive "after each" hook for "adds link to row" FAILED [$rootScope:inprog] $digest already in progress https://errors.angularjs.org/1.7.8/$rootScope/inprog?p0=%24digest beginPhase@coalahtml/_coalahtml/bower_components/angular/angular.js:19758:88 $digest@coalahtml/_coalahtml/bower_components/angular/angular.js:19088:19 flush@node_modules/angular-mocks/angular-mocks.js:2035:45 tests/specs/directives/TableRowLinksDirectiveSpec.js:37:23 PhantomJS 2.1.1 (Linux 0.0.0): Executed 21 of 26 (9 FAILED) (0 secs / 0.038 secs) PhantomJS 2.1.1 (Linux 0.0.0): Executed 21 of 26 (9 FAILED) (0.245 secs / 0.038 secs) npm ERR! Test failed. See above for more details. ```

docker run --volume=$(pwd):/app --workdir=/app coala/base coala-ci

``` Unable to find image 'coala/base:latest' locally latest: Pulling from coala/base Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff Status: Downloaded newer image for coala/base:latest WARNING:root:Use of `coala-ci` binary is deprecated, use `coala --non-interactive` instead. Executing section all... Executing section all.js... Executing section all.css... Executing section all.html... Executing section all.python... Executing section all.commit... Executing section all.autopep8... Executing section all.json... Executing section all.yaml... Executing section cli... ```

TravisBuddy Request Identifier: 33c12e00-ef93-11e9-a922-b7efe53f32d4

aitikgupta commented 5 years ago

Can anybody help me out here? I fixed #151 and #156 It didn't involve changes to the codebase, yet the build fails for some reason.

coala / coala-html