.coafile: Add commit message checking (BUGGED)

Mixih commented 8 years ago

When using coala to check the files before comitting, check for proper formatting of the commit message

Closes https://github.com/coala/coala-html/issues/38

[x] I have rebased properly. Please see this for a tutorial.
[x] I have gone through the commit guidelines and I've followed them:
[x] I have followed the guidelines for the commit shortlog.
[x] I have followed the guidelines for the commit body.
[x] I have included the issue URL.
[x] I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
[x] I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

gitmate-bot commented 8 years ago

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
- I have followed the guidelines for the commit shortlog.
- I have followed the guidelines for the commit body.
- I have included the issue URL.
- I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

adtac commented 8 years ago

ack https://github.com/coala/coala-html/pull/88/commits/f8a3bf89628f88796bd999c15118b82447aaf9a7

adtac commented 8 years ago

@rultor merge

rultor commented 8 years ago

@rultor merge

@adtac OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 years ago

@rultor merge

@mixih @adtac Oops, I failed. You can see the full log here (spent 1min)

+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/rultor
+ docker pull yegor256/rultor
Using default tag: latest
Trying to pull repository docker.io/yegor256/rultor ... latest: Pulling from yegor256/rultor
Digest: sha256:ad3c8a7c0673df4f748c3bfaaa721b4d2d092a83cc8045577f33749f79e80e1e
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ grep --quiet '\scoala_coala-html_88\s*$'
+ docker ps --filter=status=exited
+ ls -al .
total 36
drwx--x--x   3 rultor rultor   97 Nov 21 14:27 .
drwxrwxrwt. 49 root   root   4096 Nov 21 14:27 ..
-rw-rw-r--   1 rultor rultor  444 Nov 21 14:27 end.sh
-rwxrwxr-x   1 rultor rultor  326 Nov 21 14:27 entry.sh
-rw-rw-r--   1 rultor rultor    5 Nov 21 14:27 pid
drwxrwxr-x   5 rultor rultor 4096 Nov 21 14:27 repo
-rwxrwxr-x   1 rultor rultor 4344 Nov 21 14:27 run.sh
-rw-rw-r--   1 rultor rultor  102 Nov 21 14:27 script.sh
-rw-rw-r--   1 rultor rultor 3053 Nov 21 14:27 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-6WMs:/main --env=fork=git@github.com:Mixih/coala-html.git --env=fork_branch=Mixih/commit --env=head=git@github.com:coala/coala-html.git --env=head_branch=master --env=pull_id=88 '--env=pull_title=.coafile: Add commit message checking' --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-6WMs/cid -w=/main --name=coala_coala-html_88 yegor256/rultor /main/entry.sh
Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.java /root/.m2 /root/.npm /root/.profile /root/texmf /root/.texmf-var /root/tmp /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./run.sh ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su -m r -c /home/r/script.sh
+ set -e
+ set -o pipefail
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ echo 'Nothing to do.'
Nothing to do.
+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin master
remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information.        
To git@github.com:coala/coala-html.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:coala/coala-html.git'
container 99ac08d96f426871ef7945e48d37c5569219f48ac788224940636a075751235b is dead
Mon Nov 21 14:28:52 UTC 2016

sils commented 8 years ago

@rultor merge

rultor commented 8 years ago

@rultor merge

@sils OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 years ago

@rultor merge

@mixih @sils Oops, I failed. You can see the full log here (spent 1min)

+ break
+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/rultor
+ docker pull yegor256/rultor
Using default tag: latest
Trying to pull repository docker.io/yegor256/rultor ... latest: Pulling from yegor256/rultor
Digest: sha256:ad3c8a7c0673df4f748c3bfaaa721b4d2d092a83cc8045577f33749f79e80e1e
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ grep --quiet '\scoala_coala-html_88\s*$'
+ docker ps --filter=status=exited
+ ls -al .
total 32
drwx------   3 rultor rultor   84 Nov 21 14:32 .
drwxrwxrwt. 49 root   root   4096 Nov 21 14:32 ..
-rwxrwxr-x   1 rultor rultor  326 Nov 21 14:32 entry.sh
-rw-rw-r--   1 rultor rultor    4 Nov 21 14:32 pid
drwxrwxr-x   5 rultor rultor 4096 Nov 21 14:32 repo
-rwxrwxr-x   1 rultor rultor 4344 Nov 21 14:32 run.sh
-rw-rw-r--   1 rultor rultor  102 Nov 21 14:32 script.sh
-rw-rw-r--   1 rultor rultor 3052 Nov 21 14:32 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-bmdh:/main --env=fork=git@github.com:Mixih/coala-html.git --env=fork_branch=Mixih/commit --env=head=git@github.com:coala/coala-html.git --env=head_branch=master --env=pull_id=88 '--env=pull_title=.coafile: Add commit message checking' --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-bmdh/cid -w=/main --name=coala_coala-html_88 yegor256/rultor /main/entry.sh
Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.java /root/.m2 /root/.npm /root/.profile /root/texmf /root/.texmf-var /root/tmp /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./run.sh ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su -m r -c /home/r/script.sh
+ set -e
+ set -o pipefail
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ echo 'Nothing to do.'
Nothing to do.
+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin master
remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information.        
To git@github.com:coala/coala-html.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:coala/coala-html.git'
container 34b6470a7ef3e92aae6658182a81d721557bd300d081e266cbe052156d178e3f is dead
Mon Nov 21 14:33:48 UTC 2016

jayvdb commented 8 years ago

unack f8a3bf8

jayvdb commented 8 years ago

As already aware on gitter, the builds are green but all is not well : https://travis-ci.org/coala/coala-html/builds/177549877#L445

Mixih commented 8 years ago

After looking through the circle, I believe the circle warnings aren't a problem. Coala-html doesn't need the bears to work. bears are only needed during dev linting. We can fix this by adding something to the circle config (which would be separate issue). The warnings have been the ere the last few pushes too. See https://travis-ci.org/coala/coala-html/jobs/150564234

gitmate-bot commented 8 years ago

Comment on 2407693e9c64126a56322f7537558303f62d7b34.

Shortlog of HEAD commit does not match given regex.

GitCommitBear, severity NORMAL, section commit.

tushar-rishav commented 8 years ago

@Mixih I think we may not need 4490cf0a9dbce4640982 anymore as https://github.com/coala/coala-html/pull/92 is merged now. Also, we may close https://github.com/coala/coala-html/pull/89 as https://github.com/coala/coala-html/pull/88 already has the changes from former one. So let's work on #88 only? Correct me if I miss something here. :)

jayvdb commented 8 years ago

@Mixih I think we may not need 4490cf0 anymore as #92 is merged now.

4490cf0 is the same commit from #92 ; see the proposed commits and now the git log.

rultor should hopefully automatically resolve this and merge one new commit for this PR.

jayvdb commented 8 years ago

ack 34dfae3

jayvdb commented 8 years ago

@rultor merge

rultor commented 8 years ago

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 years ago

@rultor merge

@mixih @jayvdb Oops, I failed. You can see the full log here (spent 2min)

+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/rultor
+ docker pull yegor256/rultor
Using default tag: latest
Trying to pull repository docker.io/yegor256/rultor ... latest: Pulling from yegor256/rultor
Digest: sha256:ad3c8a7c0673df4f748c3bfaaa721b4d2d092a83cc8045577f33749f79e80e1e
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ docker ps --filter=status=exited
+ grep --quiet '\scoala_coala-html_88\s*$'
+ ls -al .
total 36
drwx--x--x   3 rultor rultor   97 Nov 22 09:04 .
drwxrwxrwt. 50 root   root   4096 Nov 22 09:04 ..
-rw-rw-r--   1 rultor rultor  444 Nov 22 09:04 end.sh
-rwxrwxr-x   1 rultor rultor  326 Nov 22 09:04 entry.sh
-rw-rw-r--   1 rultor rultor    6 Nov 22 09:04 pid
drwxrwxr-x   5 rultor rultor 4096 Nov 22 09:04 repo
-rwxrwxr-x   1 rultor rultor 4344 Nov 22 09:04 run.sh
-rw-rw-r--   1 rultor rultor  102 Nov 22 09:04 script.sh
-rw-rw-r--   1 rultor rultor 3194 Nov 22 09:04 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-8410:/main --env=fork=git@github.com:Mixih/coala-html.git --env=fork_branch=Mixih/commit --env=head=git@github.com:coala/coala-html.git --env=head_branch=master --env=pull_id=88 '--env=pull_title=.coafile: Add commit message checking' --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-8410/cid -w=/main --name=coala_coala-html_88 yegor256/rultor /main/entry.sh
Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.java /root/.m2 /root/.npm /root/.profile /root/texmf /root/.texmf-var /root/tmp /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./run.sh ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su -m r -c /home/r/script.sh
+ set -e
+ set -o pipefail
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ echo 'Nothing to do.'
Nothing to do.
+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin master
remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: 3 of 4 required status checks have not succeeded: 2 expected and 1 failing.        
To git@github.com:coala/coala-html.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:coala/coala-html.git'
container 5dbd2dfab2d74a03bbb1b04eb798e45c5ce5155077776e680f5dc4ec8a24fe79 is dead
Tue Nov 22 09:05:35 UTC 2016

tushar-rishav commented 8 years ago

reack 85df54a437e001672f

jayvdb commented 8 years ago

ack 6684653

jayvdb commented 8 years ago

@rultor merge

rultor commented 8 years ago

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 years ago

@rultor merge

@mixih @jayvdb Oops, I failed. You can see the full log here (spent 1min)

+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/rultor
+ docker pull yegor256/rultor
Using default tag: latest
Trying to pull repository docker.io/yegor256/rultor ... latest: Pulling from yegor256/rultor
Digest: sha256:ad3c8a7c0673df4f748c3bfaaa721b4d2d092a83cc8045577f33749f79e80e1e
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ grep --quiet '\scoala_coala-html_88\s*$'
+ docker ps --filter=status=exited
+ ls -al .
total 36
drwx--x--x   3 rultor rultor   97 Nov 22 10:05 .
drwxrwxrwt. 49 root   root   4096 Nov 22 10:05 ..
-rw-rw-r--   1 rultor rultor  444 Nov 22 10:05 end.sh
-rwxrwxr-x   1 rultor rultor  326 Nov 22 10:05 entry.sh
-rw-rw-r--   1 rultor rultor    6 Nov 22 10:05 pid
drwxrwxr-x   5 rultor rultor 4096 Nov 22 10:05 repo
-rwxrwxr-x   1 rultor rultor 4344 Nov 22 10:05 run.sh
-rw-rw-r--   1 rultor rultor  102 Nov 22 10:05 script.sh
-rw-rw-r--   1 rultor rultor 3194 Nov 22 10:05 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-L2cQ:/main --env=fork=git@github.com:Mixih/coala-html.git --env=fork_branch=Mixih/commit --env=head=git@github.com:coala/coala-html.git --env=head_branch=master --env=pull_id=88 '--env=pull_title=.coafile: Add commit message checking' --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-L2cQ/cid -w=/main --name=coala_coala-html_88 yegor256/rultor /main/entry.sh
Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.java /root/.m2 /root/.npm /root/.profile /root/texmf /root/.texmf-var /root/tmp /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./run.sh ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su -m r -c /home/r/script.sh
+ set -e
+ set -o pipefail
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ echo 'Nothing to do.'
Nothing to do.
+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin master
remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: 3 of 4 required status checks have not succeeded: 2 expected and 1 failing.        
To git@github.com:coala/coala-html.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'git@github.com:coala/coala-html.git'
container 92e3b9217f53dd0547d30d178fc13b1f4fce6efae0cc59640261fed19bd07631 is dead
Tue Nov 22 10:06:18 UTC 2016

jayvdb commented 8 years ago

This PR is an excellent setup for https://github.com/coala/coala-bears/issues/1037 . At present, unless we fix GitCommitBear, this PR is unusable.

I suggest creating a new PR, and letting me keep playing with this PR and the @Mixih branch "Mixih/commit"

gitmate-bot commented 8 years ago

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot commented 8 years ago

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot commented 7 years ago

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot commented 7 years ago

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot commented 7 years ago

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot commented 7 years ago

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot commented 7 years ago

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

jayvdb commented 7 years ago

We have a few other test branches now, and it seems quite easy to create this scenario.

coala / coala-html

.coafile: Add commit message checking (BUGGED) #88