gitmate-bot
commented
8 years ago Thanks for your contribution!
Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
- I have rebased properly. Please see this for a tutorial.
- I have gone through the commit guidelines and I've followed them:
- I have followed the guidelines for the commit shortlog.
- I have followed the guidelines for the commit body.
- I have included the issue URL.
- I have used the
Fixeskeyword if the commit fixes a real bug and theCloseskeyword if it adds a feature/enhancement. See more here.
- I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!
Mixih
sils
Note this is the proper pull request which should not have the merge bug. (coala/coala-bears#1037) See #88 for original solution and the bug that happened with Github This should have truly fixed it.
When pushing to the coaal-html repository, check the commit message formatting to make sure it conforms to coala project standards.
Fixes #38