coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

Remove tests.sh #111

Closed jayvdb closed 7 years ago

jayvdb commented 7 years ago

tests.sh is a wrapper of pytest, which uses env_variables.sh to set some environment variables.

The only difference to running pytest directly is that tests.sh will add command line arg --doctest-modules only on Linux, however addopts in setup.py already includes this option, so this had no effect at all.

Removal of this has just been done on coala (https://github.com/coala/coala-quickstart/issues/106) after the code coverage use of environment variables was replaced with coveragepy plugins which did the same thing.

tests.sh still exists in coala-bears, as it enforces 100% coverage on Linux, but not on Windows. This situation doesnt exist in coala-quickstart, and the goal should be to design the tests so that they eventually have 100% coverage on both platforms.