search

coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

CI: Remove pytest wrapper .ci/tests.sh #112

Closed jayvdb closed 7 years ago

jayvdb commented 7 years ago

Removes pytest wrapper .ci/tests.sh, and .ci/env_variables.sh which was only used by .ci/tests.sh.

Combined they only controlled whether --doctest-modules would be added to the pytest command line, but it is already part of the addopts in setup.py, so this had no effect at all.

Closes https://github.com/coala/coala-quickstart/issues/111 Related to https://github.com/coala/coala-quickstart/issues/106

jayvdb commented 7 years ago

Note also that there is only one problem with the doctests on Windows, as found and fixed at https://github.com/coala/coala-quickstart/pull/98

satwikkansal commented 7 years ago

I tried to add Appveyor on top of this PR and the build was successful :) https://ci.appveyor.com/project/satwikkansal/coala-quickstart/build/job/fefbpw5lmhsjdnwk

jayvdb commented 7 years ago

This commit isnt needed for your Appveyor PR; this commit only proves that your Appveyor PR doesnt benefit from using tests.sh , etc. Anyway ... can I has acks??

satwikkansal commented 7 years ago

This commit isnt needed for your Appveyor PR; this commit only proves that your Appveyor PR doesnt benefit from using tests.sh.

Yes, the command bash .ci/tests.sh in appveyor.yml was causing problem in my earlier Appveyor PR because tests.sh used python3. I replaced it with pytest and now it works. Sorry for the confusion and thanks for the PR :)

satwikkansal commented 7 years ago

ack c846dc1

jayvdb commented 7 years ago

@rultor merge

jayvdb commented 7 years ago

reack c846dc1

rultor commented 7 years ago

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 7 years ago

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)