Enable quote bears - Githubissues

coala / coala-quickstart

A tool that generates an initial coala config file for you!

GNU Affero General Public License v3.0

47 stars 76 forks source link

Enable quote bears #169

Closed MalkmusT closed 6 years ago

MalkmusT commented 7 years ago

This PR contains two commits. In the first one the QuoteBear is enabled for the coala-quickstart. The second one contains the automatic fixes of QuoteBear.

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file setup.py, line 23.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/setup.py
+++ b/setup.py
@@ -20,7 +20,7 @@
           description='Quickstart for coala (Code Analysis Application)',
           author="The coala developers",
           maintainer="Adrian Zatreanu, Alexandros Dimos,"
-                     "Adhityaa Chandrasekar",
+                     'Adhityaa Chandrasekar',
           maintainer_email=('adrianzatreanu1@gmail.com, '
                             'alexandros.dimos.95@gmail.com, '
                             'c.adhityaa@gmail.com'),

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file setup.py, line 22.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/setup.py
+++ b/setup.py
@@ -19,7 +19,7 @@
           version='0.3.0',
           description='Quickstart for coala (Code Analysis Application)',
           author="The coala developers",
-          maintainer="Adrian Zatreanu, Alexandros Dimos,"
+          maintainer='Adrian Zatreanu, Alexandros Dimos,'
                      "Adhityaa Chandrasekar",
           maintainer_email=('adrianzatreanu1@gmail.com, '
                             'alexandros.dimos.95@gmail.com, '

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file setup.py, line 21.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/setup.py
+++ b/setup.py
@@ -18,7 +18,7 @@
     setup(name='coala-quickstart',
           version='0.3.0',
           description='Quickstart for coala (Code Analysis Application)',
-          author="The coala developers",
+          author='The coala developers',
           maintainer="Adrian Zatreanu, Alexandros Dimos,"
                      "Adhityaa Chandrasekar",
           maintainer_email=('adrianzatreanu1@gmail.com, '

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file setup.py, line 17.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/setup.py
+++ b/setup.py
@@ -14,7 +14,7 @@
 with open('test-requirements.txt') as requirements:
     test_required = requirements.read().splitlines()

-if __name__ == "__main__":
+if __name__ == '__main__':
     setup(name='coala-quickstart',
           version='0.3.0',
           description='Quickstart for coala (Code Analysis Application)',

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/info_extraction/InfoTest.py, line 67.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/info_extraction/InfoTest.py
+++ b/tests/info_extraction/InfoTest.py
@@ -64,4 +64,4 @@
                 "\(<class 'str'>, <class 'int'>\) \(provided value: 5.5\)"):
             self.InfoA("source_file", 5.5)

-        self.InfoB("source_file", 5.5)
+        self.InfoB('source_file', 5.5)

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/info_extraction/InfoTest.py, line 65.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/info_extraction/InfoTest.py
+++ b/tests/info_extraction/InfoTest.py
@@ -62,6 +62,6 @@
                 TypeError,
                 "value must be an instance of one of "
                 "\(<class 'str'>, <class 'int'>\) \(provided value: 5.5\)"):
-            self.InfoA("source_file", 5.5)
+            self.InfoA('source_file', 5.5)

         self.InfoB("source_file", 5.5)

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/info_extraction/InfoTest.py, line 63.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/info_extraction/InfoTest.py
+++ b/tests/info_extraction/InfoTest.py
@@ -60,7 +60,7 @@
     def test_value_type(self):
         with self.assertRaisesRegexp(
                 TypeError,
-                "value must be an instance of one of "
+                'value must be an instance of one of '
                 "\(<class 'str'>, <class 'int'>\) \(provided value: 5.5\)"):
             self.InfoA("source_file", 5.5)

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/info_extraction/InfoTest.py, line 34.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/info_extraction/InfoTest.py
+++ b/tests/info_extraction/InfoTest.py
@@ -31,7 +31,7 @@

         class InfoB(Info):
             description = "Info class without value_type"
-            example_values = [["literally", "anything"]]
+            example_values = [["literally", 'anything']]

         self.info_a = InfoA(
             'source_file',

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/info_extraction/InfoTest.py, line 34.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/info_extraction/InfoTest.py
+++ b/tests/info_extraction/InfoTest.py
@@ -31,7 +31,7 @@

         class InfoB(Info):
             description = "Info class without value_type"
-            example_values = [["literally", "anything"]]
+            example_values = [['literally', "anything"]]

         self.info_a = InfoA(
             'source_file',

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/info_extraction/InfoTest.py, line 33.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/info_extraction/InfoTest.py
+++ b/tests/info_extraction/InfoTest.py
@@ -30,7 +30,7 @@
             example_values = ['coala', 420]

         class InfoB(Info):
-            description = "Info class without value_type"
+            description = 'Info class without value_type'
             example_values = [["literally", "anything"]]

         self.info_a = InfoA(

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 59.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -56,7 +56,7 @@

         bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")

-        files_list = res["HTML"]["files"].value.replace(" ", "").split(",")
+        files_list = res["HTML"]["files"].value.replace(" ", "").split(',')

         self.assertEqual(
             ['HTMLLintBear', 'coalaBear', 'BootLintBear',

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 59.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -56,7 +56,7 @@

         bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")

-        files_list = res["HTML"]["files"].value.replace(" ", "").split(",")
+        files_list = res["HTML"]["files"].value.replace(" ", '').split(",")

         self.assertEqual(
             ['HTMLLintBear', 'coalaBear', 'BootLintBear',

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 59.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -56,7 +56,7 @@

         bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")

-        files_list = res["HTML"]["files"].value.replace(" ", "").split(",")
+        files_list = res["HTML"]["files"].value.replace(' ', "").split(",")

         self.assertEqual(
             ['HTMLLintBear', 'coalaBear', 'BootLintBear',

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 59.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -56,7 +56,7 @@

         bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")

-        files_list = res["HTML"]["files"].value.replace(" ", "").split(",")
+        files_list = res["HTML"]['files'].value.replace(" ", "").split(",")

         self.assertEqual(
             ['HTMLLintBear', 'coalaBear', 'BootLintBear',

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 59.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -56,7 +56,7 @@

         bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")

-        files_list = res["HTML"]["files"].value.replace(" ", "").split(",")
+        files_list = res['HTML']["files"].value.replace(" ", "").split(",")

         self.assertEqual(
             ['HTMLLintBear', 'coalaBear', 'BootLintBear',

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 57.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -54,7 +54,7 @@
         res = generate_settings(
             project_dir, project_files, ignore_globs, relevant_bears, {}, True)

-        bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")
+        bears_list = res["HTML"]["bears"].value.replace(" ", "").split(',')

         files_list = res["HTML"]["files"].value.replace(" ", "").split(",")

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 57.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -54,7 +54,7 @@
         res = generate_settings(
             project_dir, project_files, ignore_globs, relevant_bears, {}, True)

-        bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")
+        bears_list = res["HTML"]["bears"].value.replace(" ", '').split(",")

         files_list = res["HTML"]["files"].value.replace(" ", "").split(",")

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 57.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -54,7 +54,7 @@
         res = generate_settings(
             project_dir, project_files, ignore_globs, relevant_bears, {}, True)

-        bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")
+        bears_list = res["HTML"]["bears"].value.replace(' ', "").split(",")

         files_list = res["HTML"]["files"].value.replace(" ", "").split(",")

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 57.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -54,7 +54,7 @@
         res = generate_settings(
             project_dir, project_files, ignore_globs, relevant_bears, {}, True)

-        bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")
+        bears_list = res["HTML"]['bears'].value.replace(" ", "").split(",")

         files_list = res["HTML"]["files"].value.replace(" ", "").split(",")

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 57.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -54,7 +54,7 @@
         res = generate_settings(
             project_dir, project_files, ignore_globs, relevant_bears, {}, True)

-        bears_list = res["HTML"]["bears"].value.replace(" ", "").split(",")
+        bears_list = res['HTML']["bears"].value.replace(" ", "").split(",")

         files_list = res["HTML"]["files"].value.replace(" ", "").split(",")

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 46.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -43,7 +43,7 @@
         self.assertEqual(result_comment, line)

     def test_allow_complete_section_mode(self):
-        project_dir = "/repo"
+        project_dir = '/repo'
         project_files = ['/repo/hello.html']
         ignore_globs = []

gitmate-bot commented 7 years ago

Comment on 912456a7bdeddd6c44060b88cc1a66592e8d3464, file tests/generation/SettingsTest.py, line 34.

You do not use the preferred quotation marks.

QuotesBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/tests/generation/SettingsTest.py
+++ b/tests/generation/SettingsTest.py
@@ -31,7 +31,7 @@
         sys.argv = self.old_argv

     def test_write_info(self):
-        result_date = date.today().strftime("%d %b %Y")
+        result_date = date.today().strftime('%d %b %Y')
         result_comment = ('# Generated by coala-quickstart on '
                           '{date}.\n'.format(date=result_date))
         write_info(self.writer)

satwikkansal commented 7 years ago

The diff coverage check isn't really required over here, as this PR has no functional changes.

MalkmusT commented 7 years ago

@satwikkansal thanks for the review. PR is changed as you suggested.

satwikkansal commented 7 years ago

ack ebafc05

satwikkansal commented 7 years ago

@MalkmusT around? Sorry to bother you but this PR has merge conflicts with master. Could you please rebase, run coala again, and force push to fix this.

MalkmusT commented 7 years ago

@satwikkansal branch is rebased to the acctual master and fixed as suggested. Still the code coverage test fails.

satwikkansal commented 7 years ago

Hey @MalkmusT, this time it seems like some already known non deterministic error with the Appveyor builds (see https://github.com/coala/coala-quickstart/issues/171). For some reason, I'm not able to load the CircleCI logs, but I think it may pass after triggering few rebuilds (from the past experience).

MalkmusT commented 7 years ago

@satwikkansal now the appveyor is happy. About the circleCI failure, no clue....

circleCI reports: 'circle.yml specified cache directory: /home/ubuntu/.pyenv/versions/3.5.1 but it does not exist' Maybe this is related.

satwikkansal commented 7 years ago

@MalkmusT Could you try to "Rebuild without cache" (there's an option in the dropdown next to the rebuild button on the CircleCI dashboard)

satwikkansal commented 6 years ago

Solved with https://github.com/coala/coala-quickstart/pull/231, closing this due to inactivity.

Previous