coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

Setup.py: Remove retro acronym #184

Closed Divya063 closed 7 years ago

Divya063 commented 7 years ago

This removes all instances of (code analysis application) from the repo Fixes https://github.com/coala/coala-quickstart/issues/178

gitmate-bot commented 7 years ago

Comment on 13adf28aebf6e4992c263643587929d6a41de4d1.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'removed'

Origin: GitCommitBear, Section: commit.

gitmate-bot commented 7 years ago

Comment on 13adf28aebf6e4992c263643587929d6a41de4d1.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'removed'

Origin: GitCommitBear, Section: commit.

Divya063 commented 7 years ago

@prnvdixit squashed the commits and issue reference is working fine

Divya063 commented 7 years ago

@prnvdixit Do you mean I should amend the commit?

prnvdixit commented 7 years ago

@Divya063 Yeah... that would be sufficient. Use git commit -a --amend for same. Also, refer to Commit Guidelines while doing same... :+1:

Divya063 commented 7 years ago

@prnvdixit I guess this is fine now

Makman2 commented 7 years ago

Please add inside the commit body Closes <full-url-to-issue-fixed-by-your-commit> ;)

Divya063 commented 7 years ago

@Makman2 Is this fine now?

Divya063 commented 7 years ago

@prnvdixit Thanks for the help

Divya063 commented 7 years ago

@prnvdixit I have never devoted so much time in just fixing the commit body. 😅

Makman2 commented 7 years ago

@rultor merge

rultor commented 7 years ago

@rultor merge

@makman2 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 7 years ago

@rultor merge

@makman2 Done! FYI, the full log is here (took me 2min)