search

coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

.gitignore: Add .DS_Store #204

Closed radonys closed 6 years ago

radonys commented 6 years ago

.DS_Store doesn't contain any information.

Fixes https://github.com/coala/coala-quickstart/issues/198

ishanSrt commented 6 years ago

unack https://github.com/coala/coala-quickstart/commit/1f4e80c9f913b5e33423c07f7f443044068ca221

ishanSrt commented 6 years ago

@radonys Please go through this: http://api.coala.io/en/latest/Developers/Git_Basics.html

If you submit a Pull Request from your fork’s master branch, maintainers will assume that you didn’t read this guide. coala developers may even reject your work (even if it is a good patch), because you are showing you haven’t checked our documentation. The reason why you should never develop on your master branch is because your fork’s master branch should always be synchronized with the main repository’s master branch, which is much more challenging if it has new commits on it.

prnvdixit commented 6 years ago

Also, regarding not pushing from your "master" branch - Its quite a good practice, just keep that in mind next time onwards :smile: For now, just amend your commit using git commit --amend :+1: