search

coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

coala-quickstart not evaluating file globs in some case #211

Closed ishanSrt closed 6 years ago

ishanSrt commented 6 years ago

The particular case in which file globs are not evaluated are when coala specifically asks for Which files to ignore ?. You are only able to specify one file and it adds the file name blankly to ignore field. <actually it will start adding the ignore field after PR https://github.com/coala/coala-quickstart/pull/209 is merged so you should check that out>

Steps to reproduce

mkdir project
cd project
touch a.html b.html c.html main.css
coala-quickstart

At Which files to ignore ? Enter

*.css

In the .coafile file generated there should be main.css where as there would be *.css. You might want to look at this condition as globs are evaluated in all other conditions : https://github.com/coala/coala-quickstart/blob/50b358a60454932c0c33fe9443f305abd1103b11/coala_quickstart/generation/FileGlobs.py#L41

also add a test case confirming these changes

type/bug

ishanSrt commented 6 years ago

Actually I am now not that sure whether there should be main.css or *.css is fine too. You will have to investigate that.

ishanSrt commented 6 years ago

Also you will have to ensure that more that one files/globs can be passed.

ishanSrt commented 6 years ago

status/invalid files setting is supposed to use file globs