Closed ishanSrt closed 6 years ago
blocked by broken CI. I cant even see issues raised about these CI problems.
Does that mean we dont have test coverage of this? Can tests be added?
Adding tests would require proper understanding of all the regexes involved. This snippet of code was taken from https://github.com/coala/coala-quickstart/blob/master/coala_quickstart/generation/Project.py#L49, and I'm not sure what's the best way to deal with testing such scenarios. We can have a look at the tests at editorconifg's repo, and imitate them here, or we just keep it the way it is right now.
This issue occurred because I changed the function name and forgot to change it in the recursive calls. Logic wise the code is same as https://github.com/coala/coala-quickstart/blob/master/coala_quickstart/generation/Project.py#L49
IMO, if we have to add tests about editorconfig parsing related stuff, that should be separate medium difficulty issue.
Comment on 36c142b4c96d67bdb982e53b762436639b47a310.
Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.
Origin: GitCommitBear, Section: commit
.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Comment on 36c142b4c96d67bdb982e53b762436639b47a310.
Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.
Origin: GitCommitBear, Section: commit
.
created issue https://github.com/coala/coala-quickstart/issues/232
@gitmate-bot ff
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:
Automated fastforward with GitMate.io was successful! :tada:
Closes https://github.com/coala/coala-quickstart/issues/223