coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

EditorconfigParsing.py: Correct function name #225

Closed ishanSrt closed 6 years ago

ishanSrt commented 6 years ago

Closes https://github.com/coala/coala-quickstart/issues/223

jayvdb commented 6 years ago

blocked by broken CI. I cant even see issues raised about these CI problems.

jayvdb commented 6 years ago

Does that mean we dont have test coverage of this? Can tests be added?

satwikkansal commented 6 years ago

Adding tests would require proper understanding of all the regexes involved. This snippet of code was taken from https://github.com/coala/coala-quickstart/blob/master/coala_quickstart/generation/Project.py#L49, and I'm not sure what's the best way to deal with testing such scenarios. We can have a look at the tests at editorconifg's repo, and imitate them here, or we just keep it the way it is right now.

This issue occurred because I changed the function name and forgot to change it in the recursive calls. Logic wise the code is same as https://github.com/coala/coala-quickstart/blob/master/coala_quickstart/generation/Project.py#L49

IMO, if we have to add tests about editorconfig parsing related stuff, that should be separate medium difficulty issue.

gitmate-bot commented 6 years ago

Comment on 36c142b4c96d67bdb982e53b762436639b47a310.

Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.

Origin: GitCommitBear, Section: commit.

TravisBuddy commented 6 years ago

Travis tests have failed

Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

3rd Build

coala --non-interactive ``` [WARNING][00:22:30] Implicit 'Default' section inheritance is deprecated. It will be removed soon. To silence this warning remove settings in the 'Default' section from your coafile. You can use dots to specify inheritance: the section 'all.python' will inherit all settings from 'all'. Executing section python... Executing section autopep8... **** PEP8Bear [Section | Severity NORMAL] **** ! ! The code does not comply to PEP8. [----] /home/travis/build/coala/coala-quickstart/coala_quickstart/info_extractors/EditorconfigParsing.py [++++] /home/travis/build/coala/coala-quickstart/coala_quickstart/info_extractors/EditorconfigParsing.py [ 407] pat[index:pos], [ 408] nested=True)) [ 407] pat[index:pos], [ 408] nested=True)) [INFO][00:22:40] Applied 'ShowPatchAction' on 'coala_quickstart/info_extractors/EditorconfigParsing.py' from 'PEP8Bear'. [WARNING][00:22:40] PycodestyleBear (E122): This result has no patch attached. [WARNING][00:22:40] PycodestyleBear (E122): This result has no patch attached. coala_quickstart/info_extractors/EditorconfigParsing.py [ 407] ····························pat[index:pos], **** PycodestyleBear (E122) [Section: autopep8 | Severity: NORMAL] **** ! ! E122 continuation line missing indentation or outdented coala_quickstart/info_extractors/EditorconfigParsing.py [ 408] ····························nested=True)) **** PycodestyleBear (E122) [Section: autopep8 | Severity: NORMAL] **** ! ! E122 continuation line missing indentation or outdented Executing section linelength... Executing section commit... Executing section yml... [WARNING][00:22:43] No files matching '/home/travis/build/coala/coala-quickstart/tests/**/*.yml' were found. If this rule is not required, you can remove it from section [yml] in your .coafile to deactivate this warning. Executing section cli... ```
gitmate-bot commented 6 years ago

Comment on 36c142b4c96d67bdb982e53b762436639b47a310.

Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.

Origin: GitCommitBear, Section: commit.

ishanSrt commented 6 years ago

created issue https://github.com/coala/coala-quickstart/issues/232

jayvdb commented 6 years ago

ack https://github.com/coala/coala-quickstart/pull/225/commits/9d52cb1b4595a56f863c7a9593b85cc4b9da4998

jayvdb commented 6 years ago

@gitmate-bot ff

gitmate-bot commented 6 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 6 years ago

Automated fastforward with GitMate.io was successful! :tada: