search

coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

Add editorconfig tests #232

Open ishanSrt opened 6 years ago

ishanSrt commented 6 years ago

https://github.com/coala/coala-quickstart/pull/225#issuecomment-391850187

jayvdb commented 6 years ago

This may not need to be done if https://github.com/coala/coala-quickstart/issues/222 is fix by using upstream properly.

ishanSrt commented 6 years ago

not a bug in upstream, this issue could be held off for the while

jayvdb commented 6 years ago

If upstream has tests, and we remove our copy of their code, we dont need tests for their code.

ishanSrt commented 6 years ago

@jayvdb upstream has tests what do you mean by remove our copy of their code??

jayvdb commented 6 years ago

https://github.com/coala/coala-quickstart/issues/222

We have a copy of their code.

ishanSrt commented 6 years ago

@jayvdb I know that. But what do you mean by remove the copy of the code? How will quickstart function without that?