Closed djmgit closed 6 years ago
you need to increase test coverage
also check if the help messages are meaningful in case of --non-interactive
session, and fix that over here too
@ishanSrt will update my PR ASAP.
We can ignore the codecov diff error if this is simply changing some UI messages and not introducing new branches in the logic.
@jayvdb @ishanSrt I have checked the --non-interactive
session, the help message is not showing up, as it should be.
Also, presently help messages are not tested. For example GLOB_HELP test message is not tested. So should I go for test here?
For example GLOB_HELP test message is not tested. So should I go for test here?
yes QuickStart already lacks behind on coverage than other repos, if we've gotta chance to increase tests, we should never fall behind
@jayvdb @ishanSrt @satwikkansal I was going to amend this commit and add tests but now it seems there is an issue dedicated for this : #254. So should I add tests as a part of this PR or should I add tests as a PR to issue #254 ?
No that issue is opened recently and not related to your issue, add tests over here itself, for your changes
Hey @djmgit, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Comment on 7a119fd5f4884120188b6b861b6147df1c8a08b8.
No newline found between shortlog and body at HEAD commit. Please add one.
Origin: GitCommitBear, Section: all.commit
.
Hey @djmgit, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @djmgit, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
@ishanSrt @jayvdb not sure why travis is failing. I have ran tests locally using python setup.py test
and the tests are running without any error.
The logs (https://travis-ci.org/coala/coala-quickstart/jobs/392166113) show
Traceback (most recent call last):
...
File "/home/travis/virtualenv/python3.4.6/lib/python3.4/site-packages/_pytest/vendored_packages/pluggy.py", line 515, in load_setuptools_entrypoints
"Plugin %r could not be loaded: %s!" % (ep.name, e))
_pytest.vendored_packages.pluggy.PluginValidationError: Plugin 'timeout' could not be loaded: (pytest 3.0.7 (/home/travis/virtualenv/python3.4.6/lib/python3.4/site-packages), Requirement.parse('pytest>=3.6.0'))!
This was a problem fixed by https://github.com/coala/coala-quickstart/pull/255
@gitmate-bot rebase
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:
Automated rebase with GitMate.io was successful! :tada:
@jayvdb please have a look, I have done the requested changes.
@gitmate-bot rebase
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:
Automated rebase with GitMate.io was successful! :tada:
@gitmate-bot ff
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:
Automated fastforward with GitMate.io was successful! :tada:
coala_quickstart/Strings.py: Updated GLOB_HELP message and added PROJECT_DIR_HELP message.
coala_quickstart.py: Displayed help message for project directory question.
Closes #252