search

coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

Switch to use coala-utils.Question #261

Open yzgyyang opened 6 years ago

yzgyyang commented 6 years ago

IMO we should switch to use components in coala-utils like this one:

https://github.com/coala/coala-quickstart/blob/master/coala_quickstart/generation/SettingsFilling.py#L215

Use this instead: https://gitlab.com/coala/coala-utils/blob/master/coala_utils/Question.py

(Note that it's currently blocked by https://gitlab.com/coala/coala-utils/issues/63)

gitmate-bot commented 6 years ago

GitMate.io thinks the contributor most likely able to help you is @satwikkansal.

jayvdb commented 6 years ago

To do this, the repo will need to install coala-utils, coala & coala-bears from git, not pypi

Something like https://github.com/coala/coala-bears/commit/6906e5465123ecd46e41b603b725bb4d188a23c6

However this will create a version conflict with coala-utils, as coala doesnt use coala-utils master. That needs to be done first. And that depends on https://github.com/di/pytest-reqs/issues/16 :P

jayvdb commented 6 years ago

Did a bunch of PRs to get that moving https://github.com/di/pytest-reqs/pulls

jayvdb commented 6 years ago

https://pypi.org/project/argparse-prompt/ looks very interesting.

It looks like that might be very suitable for quickstart, allowing lots of options to be exposed to the CLI, or be deferred to the user as prompts.

It may not work for all of the prompts currently in quickstart, but even moving a few of the custom prompts to become argparse-prompt would be a big win for usability.