search

coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

Settings.py: Unused variables #264

Closed ankitxjoshi closed 6 years ago

ankitxjoshi commented 6 years ago

Pyflakes error report =>

./generation/Settings.py:55: local variable 'all_files' is assigned to but never used
./generation/Settings.py:62: local variable 'gitignore_files' is assigned to but never used

Fix errors and run pyflakes==2.0.0 to ensure all are resolved. difficulty/newcomer

sjha2048 commented 6 years ago

please assign me this issue

ishanSrt commented 6 years ago

ping @adtac maybe there were added there to extend it in the future?

jayvdb commented 6 years ago

These variables were added in the first version 7c98e485 , and they were used within the logic.

6adab903 is the commit which made all_files and gitignore_files unused.

That is your puppy @ishanSrt ;-)

A quick squiz at the code changes you made and I think these are now useless and not likely to be ever helpful in this context.

I guess there must have been some reason why the logic was there, but it wasnt implemented correctly, and is not worth revisiting.

Just delete.

sjha2048 commented 6 years ago

I am really sorry for my inactivity and my behavior can I try another issue and I promise I won't mess this time.

sladyn98 commented 6 years ago

Assign me this one ill do it .