Closed ishanSrt closed 6 years ago
Hey @ishanSrt, Something went wrong with the build.
TravisCI finished with status errored
, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Something went wrong with the build.
TravisCI finished with status errored
, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
Comment on e0937563707efd2101e4b9348667aa993e7e04c0.
Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*)
Origin: GitCommitBear, Section: all.commit
.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Needs to account for .coafile
existing.
Needs to catch exceptions in bears.
And I got a non-green response from InvalidLinkBear https://gitter.im/coala/2018-gsoc-all?at=5b71ba5c5ec2bc174ff3220d
Ran it against https://github.com/kevin1024/pytest-httpbin , and it again has problems with InvalidLinkBear, and it only adds pycodestyle , and then ignores all files except for conftest.py .
Whereas it should determine that their current settings should be:
pycodestyle --max-line-length=90 --ignore=E302,E305,E251,E261,E231 .
(no errors)
Even without ignoring codes, just setting the line length would result in three files being not-ignored.
pycodestyle --max-line-length=90 pytest_httpbin/serve.py pytest_httpbin/version.py tests/util.py
You will get --ignore=E302,E305,E251,E261,E231
when --max-values
is set very high accounting, that green mode has to run coala for those many settings combination times before it gets a value that doesn't show an inconsistency
I see another bug in bear_settings.yaml
Running it against larger project requires https://github.com/coala/coala-quickstart/pull/294 . Together with the symlink problem, suggests this hasnt been tested on many repos
You will get --ignore=E302,E305,E251,E261,E231 when --max-values is set very high accounting
what value should I set for it?
I ran it without any value. Is a value mandatory? I assumed that no value means maximum value.
I assumed that no value means maximum value.
No value means a default value which is small enough so that the run time is not too long i.e. a lesser specific coafile
what value should I set for it?
The maximum number of options allowed for an optional bear setting to be checked. Depends on how much time you can afford to run the program. There are may be approx 50 error codes, so if you set the option to 50, then 50 for pycodestyle_select
and 50 for pycodestyle_ignore
means the number of runs of coala get multiplied by a factor of 50*50 extra combinations of settings
again you can limit that by setting a suitable value to --max-args
which may cause one of pycodestyle_select
or pycodestyle_ignore
to be omitted
I ran the latest version on pytest-httpbin with --max-values 50 --max-args 50
, and I still get no settings, only ignoring all files except for conftest.py
.
This is the section for pycodestyle that I get without giving any values to max_args
or max_values
[all.PycodestyleBear1]
ignore += /home/ishansrivastava/pytest-httpbin/setup.py, /home/ishansrivastava/pytest-httpbin/tests/test_server.py, /home/ishansrivastava/pytest-httpbin/tests/test_httpbin.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/serve.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/plugin.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/__init__.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs.py, /home/ishansrivastava/pytest-httpbin/tests/test_server.py, /home/ishansrivastava/pytest-httpbin/tests/test_httpbin.py
files = /home/ishansrivastava/pytest-httpbin/**.py, /home/ishansrivastava/pytest-httpbin/tests/**
On 14-Aug-2018, at 1:38 PM, John Vandenberg notifications@github.com wrote:
I ran the latest version on pytest-httpbin with --max-values 50 --max-args 50 , and I still get no settings, only ignoring all files except for conftest.py.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coala/coala-quickstart/pull/292#issuecomment-412789997, or mute the thread https://github.com/notifications/unsubscribe-auth/AceeIpyRrFwWydPFzivPGITE3zGLQZTKks5uQoWEgaJpZM4V5m19.
You don’t need that many max args but the values from here http://pycodestyle.pycqa.org/en/latest/intro.html#error-codes http://pycodestyle.pycqa.org/en/latest/intro.html#error-codes to the error codes are definitely much more than 50. I put 50 just as an example on Gitter.
Ishan Srivastava p: +91 8277536737 e: 160010013@iitdh.ac.in mailto:160010013@iitdh.ac.in, ishan.srt@gmail.com mailto:ishan.srt@gmail.com
On 14-Aug-2018, at 1:38 PM, John Vandenberg notifications@github.com wrote:
I ran the latest version on pytest-httpbin with --max-values 50 --max-args 50 , and I still get no settings, only ignoring all files except for conftest.py.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coala/coala-quickstart/pull/292#issuecomment-412789997, or mute the thread https://github.com/notifications/unsubscribe-auth/AceeIpyRrFwWydPFzivPGITE3zGLQZTKks5uQoWEgaJpZM4V5m19.
only ignoring all files except for conftest.py.
that puzzles me why is it happening for you
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
Hey @ishanSrt, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.
ack https://github.com/coala/coala-quickstart/pull/292/commits/150c041576f8e88104de91d9e14d9f4538e441ea https://github.com/coala/coala-quickstart/pull/292/commits/94e9eda139234e8b9183ce5462bd7c9a9d97e197 https://github.com/coala/coala-quickstart/pull/292/commits/8bbd4dab13853e61a1cd1a2634d0c6da72b09716 https://github.com/coala/coala-quickstart/pull/292/commits/6bf20749002220d134fe775cf978ff5b2e2e9da2 https://github.com/coala/coala-quickstart/pull/292/commits/9e91285ac87cd36ee846743f1c9d891c324f8c18 https://github.com/coala/coala-quickstart/pull/292/commits/a725f019c898a3422c856e1deae9cca906594883
@gitmate-bot ff
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:
@gitmate-bot ff
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:
Automated fastforward with GitMate.io was successful! :tada:
Hey @ishanSrt, Something went wrong with the build.
TravisCI finished with status errored
, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
This commit aggregates the per file results into sections while using the globs for the file field at the same time and produces
.coafile.green
for the project. The changes have been made such that the ignore fields are larger than files field to show inconsitencies in code to the user yet maintaining a green config file.Changes:
project_dir
at the top, folders as nodes of the tree and files as leaves of the tree.Other major changes include addition of some methods to
green_mode.py
eg.generate_data_struct_for_sections()
which takes in the per file results and creates a data structure which is given to the methodgenerate_green_mode_sections()
to create all possible sections out of it. Then sections with similar settings get their file fields combined with the use of methods fromfile_aggregator.py
andfile_globs.py
. Test are added for the above changes.