coala / coala-quickstart

A tool that generates an initial coala config file for you!
GNU Affero General Public License v3.0
47 stars 76 forks source link

green_mode: Choose job count based on environment #296

Closed jayvdb closed 5 years ago

jayvdb commented 5 years ago

Python 3.4 and 3.5 fail under our pytest configuration when the number of jobs is the cpu count - 1. On Python 3.4, an extra cpu needs to be reserved for the tests to operate smoothly on CI, and on Python 3.5 and Windows, multiprocessing needs to be disabled entirely.

Expose argument jobs throughout green_mode, so that it can be also exposed to the user or test suite for more controlled use and testing.

Related to https://github.com/coala/coala-quickstart/issues/295

TravisBuddy commented 5 years ago

Hey @jayvdb, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy commented 5 years ago

Hey @jayvdb, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

jayvdb commented 5 years ago

Depends on https://gitlab.com/coala/mobans/merge_requests/86 to pass the moban job

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @jayvdb, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

3rd Build

coala --non-interactive ``` Executing section all... Executing section all.python... **** PyUnusedCodeBear [Section | Severity NORMAL] **** ! ! This file contains unused source code. [----] /home/travis/build/coala/coala-quickstart/tests/green_mode/green_modeTest.py [++++] /home/travis/build/coala/coala-quickstart/tests/green_mode/green_modeTest.py [ 3] import sys [INFO][12:54:02] Applied 'ShowPatchAction' on 'tests/green_mode/green_modeTest.py' from 'PyUnusedCodeBear'. Executing section all.quotes... [WARNING][12:54:02] No files matching '/home/travis/build/coala/coala-quickstart/tests/**.py' were found. If this rule is not required, you can remove it from section [all.quotes] in your .coafile to deactivate this warning. Executing section all.autopep8... Executing section all.linelength... Executing section all.commit... Executing section all.yml... [WARNING][12:54:15] No files matching '/home/travis/build/coala/coala-quickstart/tests/**/*.yml' were found. If this rule is not required, you can remove it from section [all.yml] in your .coafile to deactivate this warning. Executing section cli... ```
TravisBuddy commented 5 years ago

Hey @jayvdb, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy commented 5 years ago

Hey @jayvdb, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy commented 5 years ago

Travis tests have failed

Hey @jayvdb, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy commented 5 years ago

Hey @jayvdb, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy commented 5 years ago

Hey @jayvdb, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy commented 5 years ago

Hey @jayvdb, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy commented 5 years ago

Hey @jayvdb, Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

satwikkansal commented 5 years ago

Feels great to see everything green after a long time :p

jayvdb commented 5 years ago

ack https://github.com/coala/coala-quickstart/pull/296/commits/4e801867d733c94d651034a3d4df8cbd4a3b6430

jayvdb commented 5 years ago

@gitmate-bot ff

gitmate-bot commented 5 years ago

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently :warning:

gitmate-bot commented 5 years ago

Automated fastforward with GitMate.io was successful! :tada: