Closed sils closed 8 years ago
Thanks for your contribution!
Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
Fixes
Closes
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!
ack 11e63a5
@rultor merge
@sils OK, I'll try to merge now. You can check the progress of the merge here
@sils Done! FYI, the full log is here (took me 2min)
Thanks for your contribution!
Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
Fixes
keyword if the commit fixes a real bug and theCloses
keyword if it adds a feature/enhancement. See more here.As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!