search

coala / community

Generic re-usable community site
https://coala-community.netlify.app
GNU Affero General Public License v3.0
19 stars 45 forks source link

python manage.py distill-local returns exit status 0 on failure #21

Open jayvdb opened 6 years ago

jayvdb commented 6 years ago

There have been a few failures to build, which havent been seen because python manage.py distill-local doesnt return a non-zero exit status.

https://github.com/coala/community/issues/19 is one such occurrence, which was with Django 2.

Here is the same occurring when using Django <2.0

https://travis-ci.org/jayvdb/coala_community/builds/311125722#L1182

jayvdb commented 6 years ago

The exception is rippling all the way up to at least Django django.core.management, so this must be a bug in manage.py , or ... ?

jayvdb commented 6 years ago

django-distill kindly worked around this by catching and exiting. It is still a bug upstream in Django IMO, but now a lower priority.

andrewda commented 6 years ago

Actually, this might also be an issue with the .travis.yml. I moved it to the after_success build step in #14, but failures in that step do not cause the entire Travis build to fail. See docs.

Let's try moving python manage.py distill-local back to the script step, but keep the .ci/deploy.sh stuff in the after_success step.

KVGarg commented 5 years ago

How to re-produce this error ? Because currently there is no such build failure while we deploy new changes !!

jayvdb commented 5 years ago

Look at distill-local source code