coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
66 stars 103 forks source link

Find a way to set the GitHub username #255

Open co-robo opened 7 years ago

co-robo commented 7 years ago

LabHub assumes the username is always a GitHub username, while this works for gitter. It doesn't work for other platforms such as Telegram, IRC, etc Opened by @yukiisbored at gitter//yukiisbored

jayvdb commented 7 years ago

There is a similar problem for issues on GitLab repos, which ideally should mention a GitLab username instead of a GitHub username.

The GitLab issue also appears for the web-frontend with https://gitlab.com/coala/landing/issues/31

Ultimately, we need a database. IMO, we should use a gspread or bitrix24 as the datastore.

jayvdb commented 6 years ago

And we also have this problem with Zulip, which is based on email addresses.

One approach is to have a 'github username' method, which each backend service implements to convert what it has, to a github username.

For the Zulip backend, it is easy to do an email address lookup via the GitHub API.

yukiisbored commented 6 years ago

@jayvdb Personally, using spreadsheet services is more of a hack rather than an actual solution for databases. Since this is essentially a key-value situation, something like Redis (or an even more permanent) solution would be preferable rather than a fully blown spreadsheet application for such athing.

yukiisbored commented 6 years ago

Most services will at least tell you what their email is. If corobo fails or the service simply doesn't have that luxury, we can just simply ask the person to set it manually.

For example:

<corobo> Hello, We've been trying to find your GitHub/GitLab account since it's needed for a lot of core features of corobo. To enable GitHub/GitLab related integrations, please tell me your GitHub/GitLab account by doing `corobo set github your_github_username` and `corobo set gitlab your_gitlab_username`
<someguy1> corobo set github someguy21
<corobo> someguy1: I've set your GitHub account to someguy21! :tada:
Makman2 commented 6 years ago

Maybe we also add some crosslink command for linking accounts into a single "corobo-account-entity"? (that bases on github)