search

coala / corobo

A bot to help newcomers onboard OS projects! It's awesome!
MIT License
65 stars 103 forks source link

Always respond uniquely/directly to the request #349

Open jayvdb opened 6 years ago

jayvdb commented 6 years ago

If multiple users are invoking commands, it can be difficult for newbies to know which response was intended for them.

if there is a unique part of the request, it should be repeated in the answer.

Otherwise, the bot should @mention the person it is responding to.

https://gitlab.com/coala/cobot/issues/56 was about the specific assign command error ~You're not a newcomer~ which doesnt indicate who is not a newcomer.

aashraybhandar1 commented 6 years ago

Can you elaborate bit on the unique part of the request? What does that mean?

jayvdb commented 6 years ago

Either the bot response should be unique , by including e.g. an issue URL , or it should mention the person who it is responding to.

jayvdb commented 6 years ago

This is bit of an audit task - there are quite a few corobo plugins which respond without any clear indication who they are responding to.

We need to work out which ones need to be fixed.

e.g. assign , and I think there is another issue about lmgtfy

however maybe nevermind plugin doesnt need to ping the person calling it.

jayvdb commented 6 years ago

https://github.com/coala/corobo/issues/333 is another issue about this

sladyn98 commented 5 years ago

a) The assign command could have the user mentioned in it eg @sladyn98 you have been assigned to the issue #issue url b) Currently with the unassign command if the user cannot be assigned then the reply does not mention the username so that would be fixed as well. c) The create issue command too needs to custom reply, currently it just replies with here you go. d) The lmgtfy could also include a target name which would make it personalized